Add Docker BuildX config #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-palmer
reviewed
Aug 20, 2024
There was a problem hiding this comment.
I'm excited to see this finished. This is a big improvement over the current pipeline configuration.
If merged, this will lead to a conflict in that PR which will need to be managed by hand.
Are you hoping to have #241 merged before this?
|
Let me know when this is ready for review and I'll do a review/run some tests |
|
I believe this is stable now. As pull requests don't use the GHA caching, or do arm64 compilation, that's harder to test. |
evan-palmer
requested changes
Aug 21, 2024
…g/blue into dev/use_buildx_bake
evan-palmer
requested changes
Aug 22, 2024
evan-palmer
approved these changes
Aug 22, 2024
evan-palmer
merged commit a8681d0
into
Robotic-Decision-Making-Lab:main
4 checks passed
|
Thanks for your work on this @amarburg! |
evan-palmer
added
backport-iron
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Allow pushing to apl-ocean-engineering * Install cppzmq-dev for Gazebo * Allow pushing to apl-ocean-engineering * Reverse change in docker.yaml action. * Preliminary version of docker-bake.hcl and updated Docker workflow. * Updated comments in Dockerfile * Attempt to allow manual triggering of builds * Nope, that's not it. * Add preliminary label to all Docker images. * Removed redundant libcppzmq-dev * Hack to lowercase repo name * Re-activate the metadata-action, go back to stages in matrix. * Add comment on lowercasing. * Place files config at correct level. * Re-activate the metadata-action, go back to stages in matrix. * Place files config at correct level. * Switch to registry cache for CI * Removed stage from matrix * Update repo URL, fix list formatting. (cherry picked from commit a8681d0) # Conflicts: # .github/workflows/docker.yaml
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Allow pushing to apl-ocean-engineering * Install cppzmq-dev for Gazebo * Allow pushing to apl-ocean-engineering * Reverse change in docker.yaml action. * Preliminary version of docker-bake.hcl and updated Docker workflow. * Updated comments in Dockerfile * Attempt to allow manual triggering of builds * Nope, that's not it. * Add preliminary label to all Docker images. * Removed redundant libcppzmq-dev * Hack to lowercase repo name * Re-activate the metadata-action, go back to stages in matrix. * Add comment on lowercasing. * Place files config at correct level. * Re-activate the metadata-action, go back to stages in matrix. * Place files config at correct level. * Switch to registry cache for CI * Removed stage from matrix * Update repo URL, fix list formatting. (cherry picked from commit a8681d0) # Conflicts: # .github/workflows/docker.yaml
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Allow pushing to apl-ocean-engineering * Install cppzmq-dev for Gazebo * Allow pushing to apl-ocean-engineering * Reverse change in docker.yaml action. * Preliminary version of docker-bake.hcl and updated Docker workflow. * Updated comments in Dockerfile * Attempt to allow manual triggering of builds * Nope, that's not it. * Add preliminary label to all Docker images. * Removed redundant libcppzmq-dev * Hack to lowercase repo name * Re-activate the metadata-action, go back to stages in matrix. * Add comment on lowercasing. * Place files config at correct level. * Re-activate the metadata-action, go back to stages in matrix. * Place files config at correct level. * Switch to registry cache for CI * Removed stage from matrix * Update repo URL, fix list formatting. (cherry picked from commit a8681d0) # Conflicts: # .github/workflows/docker.yaml
This was referenced Aug 22, 2024
amarburg
added a commit
that referenced
this pull request
Aug 22, 2024
amarburg
added a commit
that referenced
this pull request
Aug 22, 2024
amarburg
added a commit
that referenced
this pull request
Aug 22, 2024
evan-palmer
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Add Docker BuildX config (#266) * Allow pushing to apl-ocean-engineering * Install cppzmq-dev for Gazebo * Allow pushing to apl-ocean-engineering * Reverse change in docker.yaml action. * Preliminary version of docker-bake.hcl and updated Docker workflow. * Updated comments in Dockerfile * Attempt to allow manual triggering of builds * Nope, that's not it. * Add preliminary label to all Docker images. * Removed redundant libcppzmq-dev * Hack to lowercase repo name * Re-activate the metadata-action, go back to stages in matrix. * Add comment on lowercasing. * Place files config at correct level. * Re-activate the metadata-action, go back to stages in matrix. * Place files config at correct level. * Switch to registry cache for CI * Removed stage from matrix * Update repo URL, fix list formatting. (cherry picked from commit a8681d0) # Conflicts: # .github/workflows/docker.yaml * Resolve conflict while merging #266 --------- Co-authored-by: Aaron Marburg <[email protected]>
evan-palmer
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Add Docker BuildX config (#266) * Allow pushing to apl-ocean-engineering * Install cppzmq-dev for Gazebo * Allow pushing to apl-ocean-engineering * Reverse change in docker.yaml action. * Preliminary version of docker-bake.hcl and updated Docker workflow. * Updated comments in Dockerfile * Attempt to allow manual triggering of builds * Nope, that's not it. * Add preliminary label to all Docker images. * Removed redundant libcppzmq-dev * Hack to lowercase repo name * Re-activate the metadata-action, go back to stages in matrix. * Add comment on lowercasing. * Place files config at correct level. * Re-activate the metadata-action, go back to stages in matrix. * Place files config at correct level. * Switch to registry cache for CI * Removed stage from matrix * Update repo URL, fix list formatting. (cherry picked from commit a8681d0) # Conflicts: # .github/workflows/docker.yaml * Resolve conflicts while merging #266 --------- Co-authored-by: Aaron Marburg <[email protected]>
evan-palmer
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Add Docker BuildX config (#266) * Allow pushing to apl-ocean-engineering * Install cppzmq-dev for Gazebo * Allow pushing to apl-ocean-engineering * Reverse change in docker.yaml action. * Preliminary version of docker-bake.hcl and updated Docker workflow. * Updated comments in Dockerfile * Attempt to allow manual triggering of builds * Nope, that's not it. * Add preliminary label to all Docker images. * Removed redundant libcppzmq-dev * Hack to lowercase repo name * Re-activate the metadata-action, go back to stages in matrix. * Add comment on lowercasing. * Place files config at correct level. * Re-activate the metadata-action, go back to stages in matrix. * Place files config at correct level. * Switch to registry cache for CI * Removed stage from matrix * Update repo URL, fix list formatting. (cherry picked from commit a8681d0) # Conflicts: # .github/workflows/docker.yaml * Resolve conflicts while merging #266 --------- Co-authored-by: Aaron Marburg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Adds a
.docker/docker-bake.hclbuildx bake configuration file. The default behavior is to pulls images fromghcr.io/robotic-decision-making-lab/blueto prime the cache, but only push to local cache.Also updates the Github action to use buildx-bake. In CI it overrides the default config to cache to/from images in the Github package registry.
All docker images ('ci', 'robot', 'desktop' and 'desktop-nvidia') can be built with:
This is a standalone PR with the buildx config; very similar files are commited in the more complex #241. If merged, this will lead to a conflict in that PR which will need to be managed by hand.
Associated Issues
Related to #241
Testing
Above
docker buildx bakecall completes successfully. Resulting images forrollingare functional to complete joystick teleop demo.