Added loss function and unit test for Poisson Loss #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 11.56% 13.96% +2.39%
==========================================
Files 31 32 +1
Lines 2438 2456 +18
==========================================
+ Hits 282 343 +61
+ Misses 2156 2113 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The loss method and the unit test looks good to me however it will not really be useful if you did not add a derivative method like the other loss classes in this file. Without a derivative function, the framework's models are unable to utilize loss classes. |
rohansingh9001
requested changes
Jan 2, 2023
References to other Issues or PRs or Relevant literatureFixes #9 Brief description of what is fixed or changed
Other commentsI have tried adding the derivative method for the Poison loss class. Please suggest any corrections required. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs or Relevant literature
Fixes #9
Brief description of what is fixed or changed
Other comments
The unit test approximately compares the output of the implemented loss function with that of the corresponding loss function already there in TensorFlow when using the same test example as input.