Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed markdown rendering in report message #611

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

smritidoneria
Copy link
Contributor

Brief Title

In report message, text shown is appropiate and readable.

Acceptance Criteria fulfillment

  • Changed the title text visibility in report message

Fixes #610

Video/Screenshots

Screen.Recording.2024-07-23.at.12.40.52.PM.mov

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should remove showing the message content in the first place so that we don't have to handle large/complex messages here in this small window

@Spiral-Memory thoughts?

@Spiral-Memory
Copy link
Collaborator

I think that’s a good idea @sidmohanty11 .

Alternatively, we could use an ellipsis style so that when the text reaches the end of the line, it displays '...' instead of the complete message.

Both approaches seem fine to me.

@smritidoneria , which option do you think would be better for you to implement?"

@smritidoneria
Copy link
Contributor Author

Both the implementation looks good, we can go @sidmohanty11 approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown rendering issue in report message
3 participants