Added Feature to deploy previews of pull requests #638
Conversation
.github/workflows/cd-pr.yml
Outdated
| types: | ||
| - completed | ||
|
|
||
| permissions: |
There was a problem hiding this comment.
Once check if can remove any permission from here (as this workflow will have write permission)
There was a problem hiding this comment.
we will need these permissions for deploying builds to github-pages. permissions:content: write
There was a problem hiding this comment.
pages: write
id-token: write
Are these necessary ?
There was a problem hiding this comment.
pages write gives permissions to deploy from github pages and id-token I don't know, it was there in build-lint so I used it
There was a problem hiding this comment.
Try removing permissions one by one and test if it is still working fine, let's allow as less permissions as we can
.github/workflows/ci-pr.yml
Outdated
| pull_request_review: | ||
| types: submitted | ||
|
|
||
| permissions: |
There was a problem hiding this comment.
Same (but here it is less risky)
There was a problem hiding this comment.
removed and working well
.github/workflows/ci-pr.yml
Outdated
|
|
||
| env: | ||
| LAYOUT_EDITOR_BASE_URL: "/EmbeddedChat/pulls/pr-${{github.event.pull_request.number}}/layout_editor" | ||
| DOCS_BASEURL: "/EmbeddedChat/pulls/pr-${{github.event.pull_request.number}}/docs" |
There was a problem hiding this comment.
Use DOCS_BASE_URL for consistency (also make sure the application is expecting the same env variable
.github/workflows/ci-pr.yml
Outdated
| build: | ||
| if: github.event.review.state == 'approved' && (github.event.review.author_association == 'COLLABORATOR' || github.event.review.author_association == 'OWNER') | ||
| runs-on: ubuntu-latest | ||
| outputs: |
There was a problem hiding this comment.
Remove outputs as discussed and tested (as it has no use)
| with: | ||
| ref: gh-deploy | ||
|
|
||
| - name: Remove Deployment |
There was a problem hiding this comment.
Make sure it must not run if the PR is closed / merged before it got apporved
.github/workflows/cd-pr.yml
Outdated
| @@ -0,0 +1,37 @@ | |||
| name: Deploy PR-Preview | |||
There was a problem hiding this comment.
Let's rename cd-pr.yml as deploy-pr-preview.yml and ci as build-pr-preview.yml
CI/CD name is confusing as other workflow is also a part of CI
There was a problem hiding this comment.
changed the name
Pull Request Preview Deployment to GitHub Pages
Acceptance Criteria fulfillment
Video/Screenshots