Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Show 'Edit Message' Button for all message types #826

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dhairyashiil
Copy link
Contributor

@dhairyashiil dhairyashiil commented Jan 6, 2025

Brief Title

Feat: Show 'Edit Message' Button for all message types

Acceptance Criteria fulfillment

  • If an attachment message contains a description, the user should be able to edit it.
  • If an attachment message does not contain a description, the user should be able to add one.

By 'attachment,' I’m referring to: audio, video, files, and images.

Fixes #825

Video/Screenshots

edit.message.to.all.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-826 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010
Copy link
Contributor

Hey @dhairyashiil why do we need to hide edit option for attachment with no description? It might happen that user wants to add the description later so edit option will be beneficial. Also I think RC allows to edit for files without description.

@dhairyashiil
Copy link
Contributor Author

Hey @dhairyashiil why do we need to hide edit option for attachment with no description? It might happen that user wants to add the description later so edit option will be beneficial. Also I think RC allows to edit for files without description.

Correct, nice point. I’ll change the logic so that the edit option will be available to all.

There's no need to hide it for audio and video messages either, especially since we've now added the functionality to add descriptions to them as well. Thanks for bringing this up! 👍

@dhairyashiil dhairyashiil changed the title Feat: Conditionally Show 'Edit Message' Button Based on Attachment Description Feat: Show 'Edit Message' Button for all message types Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Show 'Edit Message' Button for all message types
2 participants