Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Wait for hook mutation #35025

Merged
merged 1 commit into from
Jan 24, 2025
Merged

test: Wait for hook mutation #35025

merged 1 commit into from
Jan 24, 2025

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jan 23, 2025

Proposed changes (including videos or screenshots)

It stabilizes a fragile unit test due to async mutations.

Issue(s)

Related to ARCH-1285

Steps to test or reproduce

Further comments

@tassoevan tassoevan requested a review from a team as a code owner January 23, 2025 23:53
Copy link
Contributor

dionisio-bot bot commented Jan 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 0918a84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan added this to the 7.4.0 milestone Jan 23, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (483cb99) to head (0918a84).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35025   +/-   ##
========================================
  Coverage    59.17%   59.17%           
========================================
  Files         2822     2822           
  Lines        68116    68116           
  Branches     15144    15144           
========================================
  Hits         40310    40310           
  Misses       24975    24975           
  Partials      2831     2831           
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 24, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35025/

Built to branch gh-pages at 2025-01-24 21:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@tassoevan tassoevan changed the title chore: Wait for hook mutation in test test: Wait for hook mutation Jan 24, 2025
@tassoevan tassoevan force-pushed the chore/flaky-unit-test branch 4 times, most recently from 9d4c5be to a845334 Compare January 24, 2025 19:14
@tassoevan tassoevan force-pushed the chore/flaky-unit-test branch from a845334 to 0918a84 Compare January 24, 2025 21:26
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jan 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 24, 2025
@kodiakhq kodiakhq bot merged commit 492eba9 into develop Jan 24, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the chore/flaky-unit-test branch January 24, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants