-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfixes #92
hotfixes #92
Conversation
fixed 0 flags to be -1 (hold everything, while 0 does nothing), added flags description to docstrings
+ Item.selected.setter + Item.set_info_value() + Take.set_info_value() + Take.source.setter + Take.start_offset.setter ~ fix typo in Take.add_event (take.pyi)
I'm not sure exactly what I've done. But it brang stability to my script
Previously, marker index was enum index to be used in EnumProjectMarkers2, but now the additional member Marker.enum_index : int is introduced. Marker.index now responds for the user-ID, that could be changed bu shift+click in the arrange-view
class EnvelopePoint Envelope methods: * `get_point(self, index:int) -> EnvelopePoint` * `insert_point(self, point: EnvelopePoint, sort: bool = True) -> bool:` * `set_point(self, index: int, value: EnvelopePoint, sort: bool = True) -> bool:` * `sort_points(self) -> None:`
Since `import reapy` line is needed only for keeping the version, I've made it directly by file-parcing. Now there is no strict need to import reapy before setuptools make its work.
rebased to the actual master, conflicts resolved |
As within the same commit relative to markers I've divided `region.index` (which now is user-index from edit popup) and `region.enum_index` (which is what was index previously).
I think, even with a long history of this PR, it is quite clean and easy to understand. More than, fixes really bugs, while not adding features) |
…res#112 I've added it in this branch as the branch already has `Item.is_selected.setter` property
The most surprising part here is — Enum index almost useless except of RPR.GetProjectMarker2 call. So, even if it touches some already written source code — it probably, will not be noticed but just makes behavior more stable. |
fix undo blocks
fixed 0 flags to be -1 (hold everything, while 0 does nothing), added flags description to docstrings
several properties of Item and Take could be rewritten. + set_info_value
Item.is_selected.setter
Item.set_info_value()
Take.set_info_value()
Take.source.setter
Take.start_offset.setter
~ fix typo in
Take.add_event()
(take.pyi
)region fix + Project.loop_points
Marker fix, suppose
I'm not sure exactly what I've done. But it brought stability to my script.
Previously I've met a lot of errors caused by invoking of
EnumProjectMarkers2
insidemakrer.py
P.S. I feel, the problem is deeper and somehow connected to regions, that are counted by
EbumProjectMarkers2
. I'll investigate soon.Markers indexing fix
Previously, marker index was enum index to be used in EnumProjectMarkers2, but now the additional member
Marker.enum_index : int
is introduced.Marker.index
now responses for the user-ID, that could be changed bu shift+click in the arrange-viewtake name now can be set
fix item id typo
Added envelope points
class
EnvelopePoint
Envelope methods:
get_point(self, index:int) -> EnvelopePoint
insert_point(self, point: EnvelopePoint, sort: bool = True) -> bool:
set_point(self, index: int, value: EnvelopePoint, sort: bool = True) -> bool:
sort_points(self) -> None:
Fix
import psutil
issue during installationSince
import reapy
line is needed only for keeping the version, I've made it directly by file-parcing. Now there is no strict need to import reapy before setuptools make its work.Region indexing fix
As within the same commit relative to markers I've divided
region.index
(which now is user-index from edit popup) andregion.enum_index
(which is what was index previously).Added 'Item.make_only_selected_item` method as suggested in #112
I've added it in this branch as the branch already has
Item.is_selected.setter
property