09-implemented-shopping-cart-Cart-item #9

RostyslavOnysh · 2023-09-25T10:14:16Z

No description provided.

…ce interface and implementation of this service and DTO classes

…class

okuzan

It seems like there is a lot of work that needs to be done in the services. If your application is not functioning properly, it is recommended to post a thread in the chat section discussing the issue and then provide a working solution for review. Service methods should not be overly complex. Try delegating some of the work to mappers and utility methods in entities that are responsible for updating relationships.

okuzan · 2023-09-25T11:51:04Z

src/main/java/spring/boot/bookstore/controller/ShoppingCartController.java

+
+    @PutMapping("/cart-items/{id}")
+    @PreAuthorize("hasRole('USER')")
+    @Operation(summary = "")


add description

okuzan · 2023-09-25T11:51:09Z

src/main/java/spring/boot/bookstore/controller/ShoppingCartController.java

+
+    @DeleteMapping("/{cartItemId}")
+    @PreAuthorize("hasRole('USER')")
+    @Operation(summary = "")


add description

okuzan · 2023-09-25T11:51:14Z

src/main/java/spring/boot/bookstore/controller/ShoppingCartController.java

+@RestController
+@RequestMapping("/cart")
+public class ShoppingCartController {
+


Suggested change

okuzan · 2023-09-25T11:51:47Z

src/main/java/spring/boot/bookstore/controller/ShoppingCartController.java

+    private final CartItemService cartItemService;
+
+    @PostMapping
+    @Operation(summary = "add new item")


Suggested change

@Operation(summary = "add new item")

@Operation(summary = "Add new item to a shopping cart")

okuzan · 2023-09-25T11:52:35Z

src/main/java/spring/boot/bookstore/service/cartitem/impl/CartItemServiceImpl.java

+        cartItemRepository.deleteById(id);
+    }
+}
+


remove line

okuzan · 2023-09-25T12:07:39Z

src/main/java/spring/boot/bookstore/service/cartitem/impl/CartItemServiceImpl.java

+        CartItem cartItem = new CartItem();
+        cartItem.setBook(bookRepository.getById(cartItemRequestDto.getBookId()));
+        cartItem.setQuantity(cartItemRequestDto.getQuantity());
+        Long id = userService.getAuthenticated().getId();
+        cartItem.setShoppingCart(shoppingCartRepository.getById(id));


use mapper to transform request dto to CartItem model

okuzan · 2023-09-25T12:08:04Z

src/main/java/spring/boot/bookstore/service/shoppingcart/ShoppingCartService.java

+import spring.boot.bookstore.model.ShoppingCart;
+
+public interface ShoppingCartService {
+


Suggested change

okuzan · 2023-09-25T12:08:39Z

src/main/java/spring/boot/bookstore/service/shoppingcart/impl/ShoppingCartServiceImpl.java

+            } else {
+                return null;
+            }
+        } else {
+            return null;
+        }


bad practice

okuzan · 2023-09-25T12:14:48Z

src/main/java/spring/boot/bookstore/repository/shoppingcart/ShoppingCartRepository.java

+
+@Repository
+public interface ShoppingCartRepository extends JpaRepository<ShoppingCart, Long> {
+    Optional<ShoppingCart> getUserById(Long id);


Suggested change

Optional<ShoppingCart> getUserById(Long id);

Optional<ShoppingCart> getById(Long id);

okuzan · 2023-09-25T12:15:08Z

src/main/java/spring/boot/bookstore/service/cartitem/impl/CartItemServiceImpl.java

+        cartItem.setBook(bookRepository.getById(cartItemRequestDto.getBookId()));
+        cartItem.setQuantity(cartItemRequestDto.getQuantity());
+        Long id = userService.getAuthenticated().getId();
+        cartItem.setShoppingCart(shoppingCartRepository.getById(id));


foreign key constraint error may be occuring here - what if getById returns null?

Ivan95kos

Please, fix the previous comments

Ivan95kos · 2023-09-27T17:38:01Z

src/main/java/spring/boot/bookstore/repository/cartitem/CartItemRepository.java

+@Repository
+public interface CartItemRepository extends JpaRepository<CartItem, Long> {
+    @Query("SELECT c FROM CartItem c WHERE c.shoppingCart.id =:shoppingCartId")
+    Set<CartItem> findCartItemByShoppingCartId(@Param("shoppingCartId") Long shoppingCart);


such simple queries should be handled by proper method naming, please recheck work without them and fix just naming method if required

Ivan95kos · 2023-09-27T17:39:08Z

src/main/java/spring/boot/bookstore/service/shoppingcart/impl/ShoppingCartServiceImpl.java

+@Service
+@RequiredArgsConstructor
+public class ShoppingCartServiceImpl implements ShoppingCartService {
+


Ivan95kos · 2023-09-27T17:39:17Z

src/main/java/spring/boot/bookstore/service/cartitem/impl/CartItemServiceImpl.java

+@Service
+@RequiredArgsConstructor
+public class CartItemServiceImpl implements CartItemService {
+


Ivan95kos · 2023-09-27T17:40:00Z

src/main/java/spring/boot/bookstore/repository/BookRepository.java

@@ -13,9 +14,10 @@ public interface BookRepository extends JpaRepository<Book, Long>, JpaSpecificat
    List<Book> findAllByTitleContainsIgnoreCase(String title);

    @Query("FROM Book b JOIN b.categories c WHERE c.id =:categoryId")
-    List<Book> findByCategoryId(Long categoryId, Pageable pageable);
+    List<Book> findByCategoryId(@Param("categoryId") Long categoryId,


such simple queries should be handled by proper method naming, please recheck work without them and fix just the naming method if required

1. Deleted Query 2. deleted empty lines 3. deleted comment

okuzan · 2023-09-28T10:31:23Z

src/main/java/spring/boot/bookstore/service/cartitem/CartItemService.java

+import spring.boot.bookstore.model.User;
+
+public interface CartItemService {
+


Suggested change

okuzan · 2023-09-28T10:33:14Z

src/main/java/spring/boot/bookstore/service/user/impl/UserServiceImpl.java

+    public User getAuthenticated() {
+        Authentication authentication = SecurityContextHolder.getContext().getAuthentication();
+        return userRepository.findByEmail(authentication.getName()).orElseThrow(
+                () -> new RuntimeException("Can`t find user with according email"


don't use generic runtime exception

okuzan · 2023-09-28T10:35:46Z

src/main/java/spring/boot/bookstore/service/shoppingcart/impl/ShoppingCartServiceImpl.java

+        return shoppingCartDto;
+    }
+
+    private ShoppingCart registerNewCart(User user) {


duplicated method in two services

okuzan · 2023-09-28T10:36:36Z

src/main/java/spring/boot/bookstore/service/cartitem/impl/CartItemServiceImpl.java

+        cartItemRepository.findById(id)
+                .orElseThrow(() -> new EntityNotFoundException("Can`t find cart by ID : " + id));


Suggested change

cartItemRepository.findById(id)

.orElseThrow(() -> new EntityNotFoundException("Can`t find cart by ID : " + id));

okuzan · 2023-09-28T10:37:23Z

src/main/java/spring/boot/bookstore/service/cartitem/impl/CartItemServiceImpl.java

+    }
+
+    @Override
+    public CartItemResponseDto update(UpdateQuantityDto updateQuantityDto, Long id) {


check if quantity is positive

…hod in service classes

…oid the repetitive method

Optic-Okulist added 7 commits September 25, 2023 10:50

modified pom.xml

253aa3e

was created Shopping cart classes like controller,entity,mapper,servi…

e440ae2

…ce interface and implementation of this service and DTO classes

fix checkstyle

23d7bf3

was added new method for authentication

332ead8

was added new method for authentication

a0680d5

was created Cart Item entity and services,mapper,repository for this …

3188521

…class

changelog for new entities

836c6c0

okuzan suggested changes Sep 25, 2023

View reviewed changes

Optic-Okulist added 4 commits September 26, 2023 11:40

modified shopping carts classes

4c82503

modified Cart item classes

bd0e7b9

Was modified all necessary classes

63d490a

fix checkstyle

05e5771

Ivan95kos suggested changes Sep 27, 2023

View reviewed changes

Optic-Okulist added 8 commits September 27, 2023 19:42

was added new line

9f09d79

modified BookRepository class and Book entity class.

5abc4d9

1. Deleted Query 2. deleted empty lines 3. deleted comment

modified findAllByCategoryId method

0591895

was deleted query

3d7801d

was deleted unnecessary constructor

b87c57e

rename method

96c2724

was deleted empty line and comment

3a242bb

was deleted empty line and modified setShoppingCartAndCartItems method

7216573

okuzan suggested changes Sep 28, 2023

View reviewed changes

Optic-Okulist added 4 commits September 28, 2023 12:54

This class was created to avoid duplicating the 'registerNewCart' met…

6cb3eac

…hod in service classes

Implement ShoppingCartManager with the 'registerNewCart' method to av…

6f986c2

…oid the repetitive method

modified exception type

ffc333f

deleted empty lines

0a56e74

RostyslavOnysh merged commit cb84fa4 into main Oct 1, 2023
2 checks passed

RostyslavOnysh deleted the shoppingCartBranch branch November 7, 2023 13:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

09-implemented-shopping-cart-Cart-item #9

09-implemented-shopping-cart-Cart-item #9

RostyslavOnysh commented Sep 25, 2023 •

edited

Loading

okuzan left a comment

okuzan Sep 25, 2023

okuzan Sep 25, 2023

okuzan Sep 25, 2023

okuzan Sep 25, 2023

okuzan Sep 25, 2023

okuzan Sep 25, 2023

okuzan Sep 25, 2023

okuzan Sep 25, 2023

okuzan Sep 25, 2023

okuzan Sep 25, 2023

Ivan95kos left a comment

Ivan95kos Sep 27, 2023

Ivan95kos Sep 27, 2023

Ivan95kos Sep 27, 2023

Ivan95kos Sep 27, 2023

okuzan Sep 28, 2023

okuzan Sep 28, 2023

okuzan Sep 28, 2023

okuzan Sep 28, 2023

okuzan Sep 28, 2023

	@Operation(summary = "add new item")
	@Operation(summary = "Add new item to a shopping cart")

		import spring.boot.bookstore.model.ShoppingCart;

		public interface ShoppingCartService {

	Optional<ShoppingCart> getUserById(Long id);
	Optional<ShoppingCart> getById(Long id);

		import spring.boot.bookstore.model.User;

		public interface CartItemService {

		cartItemRepository.findById(id)
		.orElseThrow(() -> new EntityNotFoundException("Can`t find cart by ID : " + id));

09-implemented-shopping-cart-Cart-item #9

09-implemented-shopping-cart-Cart-item #9

Conversation

RostyslavOnysh commented Sep 25, 2023 • edited Loading

okuzan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ivan95kos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RostyslavOnysh commented Sep 25, 2023 •

edited

Loading