Issue #1908 is null is not added when extra source columns are migrated #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 22, 2022 11:50
…fault value and not null column attributes correctly.
…ly, cannot use bind because it will quote variables with inverted commas in sql query.
bschmalhofer
reviewed
Jan 3, 2023
| @@ -288,15 +289,20 @@ sub AlterTableAddColumn { | |||
| my $SQL = qq{ALTER TABLE $Param{Table} ADD $Param{Column} $ColumnInfos{DATA_TYPE}}; | |||
|
|
|||
| if ( $ColumnInfos{LENGTH} ) { | |||
| $SQL .= " \($ColumnInfos{LENGTH}\)"; | |||
| $SQL .= " ($ColumnInfos{LENGTH})"; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think that $ColumnInfos{COLUMN_DEFAULT} should be quoted, just in case it contains a single quote character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.