Resolves issue 323 #324
Open
Resolves issue 323 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deserialization error that I have been experiencing.
DefaultFSTInt2ObjectMap's clear method not setting next to null. When the map was renamed to DefaultFSTInt2ObjectMap and an option of passing in your own map was added the clear method was also optimized and I think this was just missed.
to make more sense on the JDK-8 branch. I also changed how the javadoc doclint is disabled so that I could build the jar.
d-w-johnson
commented
Mar 14, 2022
| @@ -78,7 +78,7 @@ | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-javadoc-plugin</artifactId> | |||
| <configuration> | |||
| <additionalparam>-Xdoclint:none</additionalparam> | |||
There was a problem hiding this comment.
I know Gradle a lot better than Maven. I'm happy to remove these changes if you don't want them.
d-w-johnson
commented
Mar 14, 2022
| @@ -172,6 +172,7 @@ public void clear() { | |||
| mKeys = new int[size]; | |||
| mValues = new Object[size]; | |||
| mNumberOfElements = 0; | |||
| next = null; | |||
There was a problem hiding this comment.
This is the most important line that is needed and which fixes the issue.
d-w-johnson
commented
Mar 14, 2022
| import deserialization_cache_bug.random.DeterministicRandomGenerator; | ||
| import deserialization_cache_bug.random.RandomGenerator; | ||
|
|
||
| public class DeserializationCacheTest { |
There was a problem hiding this comment.
This test is pretty complex, but I had a really hard time reproducing the issue and tried to mimic some of the things about our complex model that might make it more likely to happen.
|
Any news on when this might get merged into master and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #323 for details. This PR includes:
1 - Some pom.xml updates that set it to use Java 8 and fix a javadoc issue that kept me from building the jar file.
2 - A complex test that can deterministically reproduce the bug.
3 - The simple one liner fix for the issue.
The fix would be good to get into other branches as well.