Skip to content

Commit

Permalink
Rename some PathIdentSegment functions
Browse files Browse the repository at this point in the history
This makes PathIdentSegment more similar to other classes used to
represent path segments.

gcc/rust/ChangeLog:

	* ast/rust-path.h
	(PathIdentSegment::is_super_segment): Rename to...
	(PathIdentSegment::is_super_path_seg): ...here.
	(PathIdentSegment::is_crate_segment): Rename to...
	(PathIdentSegment::is_crate_path_seg): ...here.
	(PathIdentSegment::is_lower_self): Rename to...
	(PathIdentSegment::is_lower_self_seg): ...here.
	(PathIdentSegment::is_big_self): Rename to...
	(PathIdentSegment::is_big_self_seg): ...here.

	(PathExprSegment::is_super_path_seg): Handle renames.
	(PathExprSegment::is_crate_path_seg): Likewise.
	(PathExprSegment::is_lower_self_seg): Likewise.
	(TypePathSegment::is_crate_path_seg): Likewise.
	(TypePathSegment::is_super_path_seg): Likewise.
	(TypePathSegment::is_big_self_seg): Likewise.
	(TypePathSegment::is_lower_self_seg): Likewise.
	* ast/rust-ast-collector.cc
	(TokenCollector::visit): Likewise.

Signed-off-by: Owen Avery <[email protected]>
  • Loading branch information
powerboat9 authored and CohenArthur committed Oct 28, 2024
1 parent 7a23231 commit 549fe6d
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 15 deletions.
8 changes: 4 additions & 4 deletions gcc/rust/ast/rust-ast-collector.cc
Original file line number Diff line number Diff line change
Expand Up @@ -711,19 +711,19 @@ TokenCollector::visit (TypePath &path)
void
TokenCollector::visit (PathIdentSegment &segment)
{
if (segment.is_super_segment ())
if (segment.is_super_path_seg ())
{
push (Rust::Token::make (SUPER, segment.get_locus ()));
}
else if (segment.is_crate_segment ())
else if (segment.is_crate_path_seg ())
{
push (Rust::Token::make (CRATE, segment.get_locus ()));
}
else if (segment.is_lower_self ())
else if (segment.is_lower_self_seg ())
{
push (Rust::Token::make (SELF, segment.get_locus ()));
}
else if (segment.is_big_self ())
else if (segment.is_big_self_seg ())
{
push (Rust::Token::make (SELF_ALIAS, segment.get_locus ()));
}
Expand Down
31 changes: 20 additions & 11 deletions gcc/rust/ast/rust-path.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,16 @@ class PathIdentSegment

location_t get_locus () const { return locus; }

bool is_super_segment () const { return as_string ().compare ("super") == 0; }
bool is_crate_segment () const { return as_string ().compare ("crate") == 0; }
bool is_lower_self () const { return as_string ().compare ("self") == 0; }
bool is_big_self () const { return as_string ().compare ("Self") == 0; }
bool is_super_path_seg () const
{
return as_string ().compare ("super") == 0;
}
bool is_crate_path_seg () const
{
return as_string ().compare ("crate") == 0;
}
bool is_lower_self_seg () const { return as_string ().compare ("self") == 0; }
bool is_big_self_seg () const { return as_string ().compare ("Self") == 0; }
};

// A binding of an identifier to a type used in generic arguments in paths
Expand Down Expand Up @@ -560,17 +566,17 @@ class PathExprSegment

bool is_super_path_seg () const
{
return !has_generic_args () && get_ident_segment ().is_super_segment ();
return !has_generic_args () && get_ident_segment ().is_super_path_seg ();
}

bool is_crate_path_seg () const
{
return !has_generic_args () && get_ident_segment ().is_crate_segment ();
return !has_generic_args () && get_ident_segment ().is_crate_path_seg ();
}

bool is_lower_self_seg () const
{
return !has_generic_args () && get_ident_segment ().is_lower_self ();
return !has_generic_args () && get_ident_segment ().is_lower_self_seg ();
}
};

Expand Down Expand Up @@ -950,16 +956,19 @@ class TypePathSegment

bool is_crate_path_seg () const
{
return get_ident_segment ().is_crate_segment ();
return get_ident_segment ().is_crate_path_seg ();
}
bool is_super_path_seg () const
{
return get_ident_segment ().is_super_segment ();
return get_ident_segment ().is_super_path_seg ();
}
bool is_big_self_seg () const
{
return get_ident_segment ().is_big_self_seg ();
}
bool is_big_self_seg () const { return get_ident_segment ().is_big_self (); }
bool is_lower_self_seg () const
{
return get_ident_segment ().is_lower_self ();
return get_ident_segment ().is_lower_self_seg ();
}
};

Expand Down

0 comments on commit 549fe6d

Please sign in to comment.