Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of InlineAsm in DefaultASTVisitor #3191

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Improve handling of InlineAsm in DefaultASTVisitor #3191

merged 1 commit into from
Oct 15, 2024

Conversation

powerboat9
Copy link
Contributor

No description provided.

@P-E-P
Copy link
Member

P-E-P commented Oct 10, 2024 •
edited
Loading

Argh, I didn't know InlineAsm did not expose a getter to a reference. We should probably add

const Expr& In::get_expr() const {
    return *expr;
}

to all In/Out structs anyway.

@powerboat9
Improve handling of InlineAsm in DefaultASTVisitor
035687d 
gcc/rust/ChangeLog:

	* ast/rust-ast-visitor.cc
	(DefaultASTVisitor::visit): Visit fields of InlineAsm.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove
	inline_asm_parse_output_operand.rs.

Signed-off-by: Owen Avery <[email protected]>
@powerboat9
Copy link
Contributor Author

This should work now that #3193 is merged

@P-E-P P-E-P added this pull request to the merge queue Oct 15, 2024
Merged via the queue into Rust-GCC:master with commit ab15db3 Oct 15, 2024
12 checks passed
@powerboat9 powerboat9 deleted the inline-asm-vis branch October 16, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerboat9 @P-E-P