Disambiguate generic args during name resolution 2.0 #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-E-P
reviewed
Oct 16, 2024
Comment on lines
+266
to
+290
| Late::visit (AST::GenericArgs &args) | ||
| { | ||
| for (auto &lifetime : args.get_lifetime_args ()) | ||
| visit (lifetime); | ||
|
|
||
| for (auto &generic : args.get_generic_args ()) | ||
| visit (generic); | ||
|
|
||
| for (auto &binding : args.get_binding_args ()) | ||
| visit (binding); | ||
| } |
There was a problem hiding this comment.
Doesn't the default visitor already visit generic args ?
There was a problem hiding this comment.
Kind of, from what I can tell GenericArg::accept_vis just visits the properties of GenericArg and there isn't a virtual method for visit (GenericArg &). Therefore, in order to get the GenericArgs visitor to call into the non-virtual GenericArg visitor, the former has to be overridden along with the latter.
There was a problem hiding this comment.
I've rebased and added a comment to the GenericArgs visitor method.
gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Visit GenericArgs and GenericArg, the former because the latter involves a non-virtual member function call. * resolve/rust-late-name-resolver-2.0.h (Late::visit): Likewise. Signed-off-by: Owen Avery <[email protected]>
P-E-P
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.