Make TyTy::TupleType::get_unit_type cache its return value
#3232
Conversation
This removes a usage of Resolver::get_unit_type_node_id in rust-hir-type-check-expr.cc (the HIR::TupleExpr overload of TypeCheckExpr::visit). gcc/rust/ChangeLog: * typecheck/rust-tyty.cc (TupleType::get_unit_type): Remove parameter, cache return value. * typecheck/rust-tyty.h (TupleType::get_unit_type): Remove parameter. * resolve/rust-late-name-resolver-2.0.cc (Late::setup_builtin_types): Adjust calls to get_unit_type. * resolve/rust-name-resolver.cc (Resolver::generate_builtins): Likewise. * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Likewise. * typecheck/rust-hir-type-check-implitem.cc (TypeCheckTopLevelExternItem::visit): Likewise. (TypeCheckImplItem::visit): Likewise. * typecheck/rust-hir-type-check-item.cc (TypeCheckItem::visit): Likewise. * typecheck/rust-hir-type-check-stmt.cc (TypeCheckStmt::visit): Likewise. * typecheck/rust-hir-type-check-type.cc (TypeCheckType::visit): Likewise. * typecheck/rust-hir-type-check.cc (TraitItemReference::get_type_from_fn): Likewise. Signed-off-by: Owen Avery <[email protected]>
|
So here we've got the same HIR id for all unit types. It seems fine but I do not know all implications so I'll let @philberty review |
There was a problem hiding this comment.
LGTM yes this is actually the right thing to do.
Historically i wasnt sure how the type system was going to work at all from reading lots of rustc. But this now makes unit-type work like the other builtins like i32.
The idea of the reference is that we have an hir node that reflects this type at this node-id. But when it comes to referencing it we update the reference but the ty_ref references the original declaration. We use this to manage generic parameter types because we can then simply replace the ty-ref on the type to point to what the new parameter points to which is still super scary to me and still suprises me that it seems to be working at all but i do have sleepless nights over it...
This removes a call to
Resolver::get_unit_type_node_id, which relies on the old resolver callingResolver::set_unit_type_node_id