Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DeviceSlice a newtype around [()] #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make DeviceSlice a newtype around [()] #44

wants to merge 3 commits into from

Conversation

beepster4096
Copy link
Contributor

This fixes some unsoundness and fixes some of DeviceSlice's methods and docs not making any sense (such as from_raw_parts_mut)

RDambrosio016
RDambrosio016 requested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@RDambrosio016 RDambrosio016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, couple of things that need to be sorted out, and the changes need to be documented in the changelog

crates/cust/src/memory/device/device_slice.rs Outdated Show resolved Hide resolved
crates/cust/src/memory/device/device_slice.rs Show resolved Hide resolved
RDambrosio016
RDambrosio016 reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@RDambrosio016 RDambrosio016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs changelog entries

@beepster4096
Copy link
Contributor Author

Alright, changelog is upodated and merge conflicts are resolved

@RDambrosio016 RDambrosio016 mentioned this pull request Mar 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDambrosio016 RDambrosio016 RDambrosio016 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beepster4096 @RDambrosio016