Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changes from the Lykensol branch Ephemera/0.10.0 #10

Closed
wants to merge 35 commits into from
Closed

Add changes from the Lykensol branch Ephemera/0.10.0 #10

wants to merge 35 commits into from

Conversation

LegNeato
Copy link
Collaborator

This is the branch wholesale with a test fix by me.

@LegNeato LegNeato mentioned this pull request Sep 16, 2024
Closed
eddyb and others added 27 commits September 17, 2024 11:16
@eddyb @LegNeato
WIP: fix CHANGELOG (TODO: missing entries!).
1cef236
@eddyb @LegNeato
examples/shaders/shared: remove unused feature(lang_items).
54e39cd
@eddyb @LegNeato
tests: also test the debugPrintf generated from panics.
ab901f3
@LegNeato
rustup: update to nightly-2023-11-26.
cc621b0
@LegNeato
rustup: update to nightly-2023-12-16.
f987e10
@LegNeato
rustup: update to nightly-2023-12-31.
d03e379
@eddyb @LegNeato
spirv-builder: disable MIR "GVN" optimization pass.
a6bfd38
@eddyb @LegNeato
builder: fix atomic_cmpxchg for SPIR-V OpAtomicCompareExchange.
eaafa1e
@eddyb @LegNeato
builder: struct_gep implies inbounds.
df5e497
@eddyb @LegNeato
rustup: update to nightly-2024-01-05.
d1bad2a
@eddyb @LegNeato
rustup: update to nightly-2024-01-06.
e422b7a
@eddyb @LegNeato
builder: handle ptr_add-like GEPs (introduced by rust-lang/rust#118991
31f4592 
).
@LegNeato
rustup: update to nightly-2024-01-08.
b61f551
@eddyb @LegNeato
rustup: update to nightly-2024-02-01.
ccbcbaf
@eddyb @LegNeato
rustup: update to nightly-2024-03-01.
f243f1a
@eddyb @LegNeato
rustup: update to nightly-2024-03-11.
8c56f53
@eddyb @LegNeato
spirv-builder: pass JSON files to --target instead of relying on th…
1978c70 
…e backend's `target_override`.
@eddyb @LegNeato
(TODO: for_range_signed broken, try fix?) rustup: update to `nightly-…
c8df469 
…2024-03-21`.
@eddyb @LegNeato
rustup: update to nightly-2024-04-01.
f670cbd
@eddyb @LegNeato
rustup: update to nightly-2024-04-24.
07f1d0a
@eddyb @LegNeato
WIP: update for spirt 0.4.0
e7652ff
@eddyb @LegNeato
tests: add test for long chain of conditional panics.
cc889b3
@eddyb @LegNeato
Use ExitInvocation for panics (avoiding deeply nested structurizati…
14a1806 
…on).
@eddyb @LegNeato
linker: centralize dumping SPIR-V and SPIR-T together.
815a64d
@eddyb @LegNeato
linker: add --dump-{pre,post}-inline to be able to debug the inliner.
7de8b6c
@eddyb @LegNeato
linker/inline: fix OpVariable debuginfo collection and insertion.
e5a4800
@eddyb @LegNeato
WIP: (TODO: finish bottom-up cleanups) bottom-up inlining
34880f5
@LegNeato
Copy link
Collaborator Author

LegNeato commented Sep 17, 2024 •
edited
Loading

This is failing due to the // ignore-vulkan1.2lines not being respected. When run under:

RUST_TEST_NOCAPTURE=1  cargo run -p compiletests --release --no-default-features --features "use-compiled-tools" -- --target-env vulkan1.1,spv1.3

They pass and this fails:

RUST_TEST_NOCAPTURE=1  cargo run -p compiletests --release --no-default-features --features "use-compiled-tools" -- --target-env vulkan1.2,spv1.3

Possibly introduced by 1978c70

@LegNeato
Make stage_id use the env
4b14058 
Without this the skip directives weren't working. This looks to
largely be legacy anyway, but tests now run and pass in the
correct environments.
@LegNeato LegNeato force-pushed the next_release branch 2 times, most recently from 3485eb3 to c1a8be0 Compare September 18, 2024 18:39
@LegNeato
Further process paths on windows
b99259d 
We have specific code to handle the path mangling on windows, but
for some reason it isn't working for these tests.

This is a hack to make them pass on windows.
@LegNeato
Copy link
Collaborator Author

Closing in favor of merging these separately

@LegNeato LegNeato closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb Awaiting requested review from eddyb eddyb is a code owner

@fornwall fornwall Awaiting requested review from fornwall fornwall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LegNeato @eddyb