Added non release (dev) shader build #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated ci.yaml to include a cargo build/run of example-runner-wgpu-builder in a dev profile (no --release)
|
Awesome, thank you so much for the change and welcome to open source contributing! 🍻 Your change will help catch issues in the future, saving many people time and effort 🎉. I have made it so CI will now run on this PR, let's see how it goes...the change looks great to me. |
|
Ah yes, silly me. #40 was created because of #29. So, running this in CI now (correctly) exposes #29 😆 . We have 2 paths forward:
@zanciks , your call! |
|
Yeah, I think we can go on with the first route! I'll add a commit here in a moment to block the test on both aarch64-linux-android, and now x86_64-apple-darwin! Edit: Commit added |
LegNeato
requested review from
LegNeato
and removed request for
eddyb and
fornwall
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all! First time contributor (to any open-source project!!!!)
I saw issue #40 and decided to try and see if I could get an action added. I've pretty much just added another example (also runs example-runner-wgpu-builder) but left out --release.
I was a bit unsure about the OUT_DIR environment variable, and if it was necessary (not even sure why it's there for the existing example run?) but I assumed it should remain for consistency.
On top of that, I was going to look at adding a dev profile build for android, but it seems that cargo-apk is outdated, and the maintainers of the project recommend xbuild, though I am unsure if profiles (--release) are forwarded to cargo or not. Will have to play around with it.
I'm also unsure if I'm able to run actions on my fork of this repo for before submitting this, so its possible that it will return an error, but at first glance it seems fine.
Thanks!