Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spirv-builder takes optional path to target spec JSON file #55

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

schell
Copy link
Contributor

@schell schell commented Nov 11, 2024

Copy link
Collaborator

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustfmt

@schell
Copy link
Contributor Author

schell commented Nov 12, 2024

Ah, yes - I forgot that since we can only build on macOS with --release, my editor's LSP doesn't work on this project...

@schell schell requested a review from LegNeato November 12, 2024 00:47
@LegNeato LegNeato enabled auto-merge November 12, 2024 00:47
@LegNeato LegNeato added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 0da80f8 Nov 12, 2024
7 checks passed
@LegNeato LegNeato deleted the feature/spirv-builder-takes-optional-target-spec-path branch November 12, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants