-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PipeWire host #651
base: master
Are you sure you want to change the base?
PipeWire host #651
Conversation
8e75170
to
aae2d78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some preliminary comments.
After digging a bit into pipewire-rs
it seems that it still lacks a lot of proper binding for essential interfaces, including device enumeration. So I guess the backend will also be blocked on that.
I also look forward to making some MRs to pipewire-rs
as a part of a different personal project, so hopefully this will be unblocked soon.
@@ -33,6 +33,8 @@ nix = "0.23" | |||
libc = "0.2.65" | |||
parking_lot = "0.11" | |||
jack = { version = "0.8", optional = true } | |||
# pipewire = { version = "0.4", optional = true } | |||
pipewire = { git = "https://gitlab.freedesktop.org/pipewire/pipewire-rs", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably doesn't matter since a git dependency can't be included in a published crate anyway, but you should suffix it the URL with .git
so GitLab doesn't complain about that.
…impl platform: Conditional impl_platform_host based on feature flags
5cba950
to
61aa078
Compare
No description provided.