Use daggy's StableDag #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix RustAudio#103. Use the StableDag structure which (which uses petgraph's StableGraph) implements a directed acyclic graph with stable indices.
Use the new Walker API.
fwcd
commented
Sep 14, 2019
| for connection in self.dag.edge_weights_mut() { | ||
| let edge_ids = self.edge_references().map(|e| e.id()).collect::<Vec<_>>(); | ||
| for edge_id in edge_ids { | ||
| let connection = self.connection_mut(edge_id).unwrap(); |
There was a problem hiding this comment.
Unfortunately, this also means that we cannot mutably iterate the graph's nodes/edges directly (yet). To address this, I have implemented this workaround which is slightly less efficient.
fwcd
commented
Sep 14, 2019
| @@ -19,7 +19,7 @@ name = "dsp" | |||
| path = "./src/lib.rs" | |||
|
|
|||
| [dependencies] | |||
| daggy = "0.4.0" | |||
| daggy = { git = "https://github.com/mitchmindtree/daggy", rev = "bcb36c7b", features = ["stable_dag"] } | |||
There was a problem hiding this comment.
Also, we might want to update to the next proper version of daggy once it is released to crates.io.
The EdgeRef trait provides information about the edges returned by Graph::edge_references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
StableDagshould fix the index-shifting behavior, which previously occurred when nodes were removed from the graph.There are a few API-breaking changes with this solution, however:
raw_nodesis replaced bynode_referencesraw_edgesis replaced byedge_referencesWalker'snext_nodeandnext_edgeare replaced bywalk_next(as defined by the upstream API)