Allow usage without Seek
: RevReader
approach
#36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented my proposal to resolve #12 .
Instead of
Seek
, the (non-seeking) functionality of thePacketReader
now requires a new traitRevRead
which allows making a single reversible read operation. This is blanket-implemented for all types implementingRead + Seek
, so business as usual is possible. Beyond that, I added theRevReader
which implementsRevRead
solely on the basis ofRead
. This allows usage of thePacketReader
with underlying readers that do not implementSeek
.The tests seem to pass (on my machine), but I have not yet tried to apply this to an OGG file where seeking is actually necessary. Do the tests cover that scenario?
Potential Drawbacks
RevRead
trait carries an annoying lifetime that is required to return references to internal state of the reader. This could probably be resolved with generic associated types (🔬 Tracking issue for generic associated types (GAT) rust-lang/rust#44265).RevReader
. I have not run any benchmarks yet, if that is necessary, please request.