Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements Seek #513

Merged
merged 67 commits into from
Apr 6, 2024
Merged

Implements Seek #513

merged 67 commits into from
Apr 6, 2024

Commits on Oct 13, 2023

  1. seek implemented through SourceExt trait

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    fafe4ba View commit details
    Browse the repository at this point in the history

  2. request pos now uses mutable self

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    023e833 View commit details
    Browse the repository at this point in the history

  3. switch to fork for cpal

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    204a3f8 View commit details
    Browse the repository at this point in the history

  4. remove seek trait from source mods, added it to symphonia decoder, re… 

    …named the trait to SeekableSource
    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    d47842f View commit details
    Browse the repository at this point in the history

  5. removes SeekableSource adds failable try_seek to Source

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    745db82 View commit details
    Browse the repository at this point in the history

  6. adds try_seek for sink and all sources

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    202687b View commit details
    Browse the repository at this point in the history

  7. removes default try_seek impl, impl try_seek for decoders + refactors… 

    … decoderimpl a bit
    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    1f3f36a View commit details
    Browse the repository at this point in the history

  8. refactors seektest and adds more formats

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    5b933d7 View commit details
    Browse the repository at this point in the history

  9. Fix seeking for mix source 

    add todo about can_seek to mix

Co-authored-by: naglis <[email protected]>
    @dvdsk @naglis
    dvdsk and naglis committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    961c3ef View commit details
    Browse the repository at this point in the history

  10. refactors seek test, now covers all decoders/formats

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    e1092f7 View commit details
    Browse the repository at this point in the history

  11. fixes symphonia seek div by zero

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    a3c55b8 View commit details
    Browse the repository at this point in the history

  12. add seek for lewton

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    d8a8be4 View commit details
    Browse the repository at this point in the history

  13. add can_seek method to source 

    document why Sink::can_seek does not exist
    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    9a4dcb0 View commit details
    Browse the repository at this point in the history

  14. refactor tests, add seek beyond stream test

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    eb22ec5 View commit details
    Browse the repository at this point in the history

  15. turns SeekNotSupported into a SeekError

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ebebe88 View commit details
    Browse the repository at this point in the history

  16. fixes symphonia seek beyond end of file returning an error

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    5d44bfe View commit details
    Browse the repository at this point in the history

  17. removes can_seek in favor of rolling back seek operations (requires PR … 

    …RustAudio#510)
    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    10262f8 View commit details
    Browse the repository at this point in the history

  18. adds test verifying correct seek position after seek

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    8416210 View commit details
    Browse the repository at this point in the history

  19. adds total_duration() impl to SymphoniaDecoder, makes seek saturating… 

    … at source end if total_duration known
    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    2b39d27 View commit details
    Browse the repository at this point in the history

  20. finishes doc for sink::try_seek

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    5de7383 View commit details
    Browse the repository at this point in the history

  21. symphonia throws error if duration is unknown and seek is beyond sour… 

    …ce length
    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    f3a1966 View commit details
    Browse the repository at this point in the history

  22. adds try_seek to spatial source

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    560961f View commit details
    Browse the repository at this point in the history

  23. revert to upstream non-seekable minimp3, comment out minimp3-seek sup… 

    …port
    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    4237eff View commit details
    Browse the repository at this point in the history

  24. Language and spelling fixes by @naglis 

    fix comment typo

Co-authored-by: naglis <[email protected]>
    @dvdsk @naglis
    dvdsk and naglis committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    3f4b530 View commit details
    Browse the repository at this point in the history

  25. fixes seek in m4a files, fixes seeking having 1 second granularity

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    82bfa41 View commit details
    Browse the repository at this point in the history

  26. formats everything with cargo fmt

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    d1a809f View commit details
    Browse the repository at this point in the history

  27. speeds up correct_remaining_playtime test

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    a24e0e6 View commit details
    Browse the repository at this point in the history

  28. completely remove sink usage from seek tests

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    724df4d View commit details
    Browse the repository at this point in the history

  29. make cargo fmt happy

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    b26194d View commit details
    Browse the repository at this point in the history

  30. refactors symphonia try_seek

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    963a484 View commit details
    Browse the repository at this point in the history

  31. improve seek beyond end documentation

    @dvdsk
    dvdsk committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    c2c85e2 View commit details
    Browse the repository at this point in the history

  32. remove commented out dead code in tests/seek.rs 

    Co-authored-by: naglis <[email protected]>
    @dvdsk @naglis
    dvdsk and naglis committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    7357f19 View commit details
    Browse the repository at this point in the history

  33. use From<f64> instead of custom time_from_duration 

    remove now unused time_from_duration

Co-authored-by: naglis <[email protected]>
    @dvdsk @naglis
    dvdsk and naglis committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    8c77462 View commit details
    Browse the repository at this point in the history

  34. Remove duplicate doc section and fix spelling in docs 

    Co-authored-by: naglis <[email protected]>

Co-authored-by: naglis <[email protected]>
    @dvdsk @naglis
    dvdsk and naglis committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    5dd4135 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Merge branch 'master' into seek_runtime_err

    @dvdsk
    dvdsk committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b7b5735 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Merge branch 'master' into seek_runtime_err

    @dvdsk
    dvdsk committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    50a781a View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @dvdsk
    dvdsk committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    57f2a3c View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge branch 'master' into seek_runtime_err

    @dvdsk
    dvdsk committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    470eba8 View commit details
    Browse the repository at this point in the history

  2. fixes spell errors in docs and SeekError

    @dvdsk
    dvdsk committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4dea149 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Fixes seek example and various spell/grammar issues 

    Co-authored-by: naglis <[email protected]>
    @dvdsk @naglis
    dvdsk and naglis committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    fb44f71 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. implement try_seek for SamplesBuffer

    @dvdsk
    dvdsk committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    766fbbf View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. seek tests finds beep in stereo test file

    @dvdsk
    dvdsk committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c60819e View commit details
    Browse the repository at this point in the history

  2. (seek/test) fixes duration calc in test

    @dvdsk
    dvdsk committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    2e9d680 View commit details
    Browse the repository at this point in the history

  3. (seek/test) adds failing test for seeking in exausted source

    @dvdsk
    dvdsk committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    67612b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. fix(seek) vorbis decoder crashing when seeking

    @dvdsk
    dvdsk committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d0fce09 View commit details
    Browse the repository at this point in the history

  2. test(seek) add test for channel order

    @dvdsk
    dvdsk committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9ae1c55 View commit details
    Browse the repository at this point in the history

  3. test(seek) improve channel order test

    @dvdsk
    dvdsk committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    04c6957 View commit details
    Browse the repository at this point in the history

  4. fix(seek) vorbis decoder now respects channel order

    @dvdsk
    dvdsk committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1c82136 View commit details
    Browse the repository at this point in the history

  5. commit to save work on vorbis try_seek

    @dvdsk
    dvdsk committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5562241 View commit details
    Browse the repository at this point in the history

  6. removes seeking from vorbis decoder, can not be implemented

    @dvdsk
    dvdsk committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    80add81 View commit details
    Browse the repository at this point in the history

  7. Vorbis actually can be implemented since the sample rate is constant 

    This reverts commit 80add81.
    @dvdsk
    dvdsk committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4e14b0a View commit details
    Browse the repository at this point in the history

  8. refactor(seek) explain why seek to sample works

    @dvdsk
    dvdsk committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3bafe32 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. remove seek support for (lewton) vorbis 

    seek is broken, RustAudio/lewton#73.
We could work around it by:
 - using unsafe to create an instance of Self
 - use mem::swap to turn the &mut self into a mut self
 - take out the underlying Read+Seek
 - make a new self and seek

If this issue is fixed use the implementation in
commit: 3bafe32
    @dvdsk
    dvdsk committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    26e9db7 View commit details
    Browse the repository at this point in the history

  2. (tests) use rstest to refactor and expand seek test 

    This adds two dependencies, they are only needed for the test suite.
Compile time will not increase for users. The extra overhead when
running the test suite is worth it imho. The test file is significantly
shorter and there is less code duplication. A run time solution would
decrease the test interface (you would have to manually find out which
params caused the test).
    @dvdsk
    dvdsk committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7eb13be View commit details
    Browse the repository at this point in the history

  3. fix(seek) hound(wav) now keeps channel order consistent

    @dvdsk
    dvdsk committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f846cdf View commit details
    Browse the repository at this point in the history

  4. refactor(decoder/symphonia) logic reorderd

    @dvdsk
    dvdsk committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a52a41b View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. test(seek) made channel order more brittle

    @dvdsk
    dvdsk committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1fcf4b8 View commit details
    Browse the repository at this point in the history

  2. refactor(decoder/sympthonia) use for loop instead loop + match & escape 

    More readable, prep for using the same lines in new refine_position fn.
Since that is already pretty complex this needed to be made simpler.

This code retries on all errors not only decode errors. Retries will not
work on anything else then a decode error however they also wont cause
any problems. Not checking the result does however make the code
simpler.
    @dvdsk
    dvdsk committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    40a9447 View commit details
    Browse the repository at this point in the history

  3. fix(decoder/symphonia) seek is no longer off

    @dvdsk
    dvdsk committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    6034af3 View commit details
    Browse the repository at this point in the history

  4. seek/error symphonia seekerror is now more precise

    @dvdsk
    dvdsk committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    aa0880d View commit details
    Browse the repository at this point in the history

  5. fix(seek/delay) seek < delay duration ate up the delay

    @dvdsk
    dvdsk committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7cf0451 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Merge branch 'master' into seek_runtime_err

    @dvdsk
    dvdsk committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    6f1f44f View commit details
    Browse the repository at this point in the history

  2. style clippy fixes

    @dvdsk
    dvdsk committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    34366fe View commit details
    Browse the repository at this point in the history

  3. fix(seek) conditional compilation

    @dvdsk
    dvdsk committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    a4d167f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into seek_runtime_err

    @dvdsk
    dvdsk committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    b49b22a View commit details
    Browse the repository at this point in the history

  5. update changelog

    @dvdsk
    dvdsk committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    bbc8f00 View commit details
    Browse the repository at this point in the history

  6. style, removes a needless clone() 

    Was needed before a cargo update call. Update to cpal made the type
copy though.
    @dvdsk
    dvdsk committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    1ed1197 View commit details
    Browse the repository at this point in the history