aead-stream: extract implementation from the aead crate #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
changed the title
tarcieri
reviewed
Sep 23, 2024
Co-authored-by: Tony Arcieri <[email protected]>
tarcieri
reviewed
Sep 23, 2024
tarcieri
reviewed
Sep 23, 2024
|
|
||
| let mut result = Array::default(); | ||
|
|
||
| // TODO(tarcieri): use `generic_array::sequence::Concat` (or const generics) |
There was a problem hiding this comment.
Sidebar: should probably fix this, or at least update it to use hybrid-array (in a separate PR seems fine)
tarcieri
reviewed
Sep 23, 2024
| @@ -0,0 +1,229 @@ | |||
| #![no_std] | |||
| #![doc = include_str!("../README.md")] | |||
| #![allow(clippy::upper_case_acronyms)] | |||
There was a problem hiding this comment.
Might be good to fix this in a separate PR
tarcieri
reviewed
Sep 23, 2024
tarcieri
approved these changes
Sep 23, 2024
newpavlov
added a commit
to RustCrypto/traits
that referenced
this pull request
Sep 23, 2024
Sibling PR: RustCrypto/AEADs#627 Closes #1665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts implementation of the STREAM construction from the
aeadcrate into a separate crate as was proposed in RustCrypto/traits#1665.