Carthage support #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example folder contains only code for Example
Integrate Carthage frameworks to Example Make RxAnimated framework scheme shared Change version number
|
Thanks @IgorBulyga, I'll have a look at the PR. I have to check out the PR locally but if you removed the development setup from the example app I'll have to reject it. |
# Conflicts: # Example/Podfile # RxAnimated.podspec # RxAnimated.xcodeproj/project.pbxproj
Update Podspec
|
@icanzilb I have merged the latest commit, where AppleTV support was added, into my PR. And provide AppleTV Framework for Carthage. For check it out for correct work you have to run carthage update --no-use-binaries --platform iOS,tvOSAnd then just open RxAnimated.xcodeproj and run examples. Everything should be fine. If you will have any questions, I'm ready to answer them. |
Closed
|
This worked great for me in terms of Carthage support, if someone can test it with Coocapods I'd say it's mergeable. |
|
Hello, Any update on this merge ? 🙂 |
|
Hey guys! Would be great to merge this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Carthage support.
Also, make some refactoring in the project hierarchy. Move project file in the root folder to produce .framework for Carthage and make Example inner target. Replace Cocoapods with Carthage for Example.