-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge updates on develop into master #52
Conversation
Update develop from master
To enable user to pass param indicating if they want their output to validate against dtd,, rng, or xsd.
Related to #40
Related to #40
Added new params to list. Related to #40
Relates to #40
Needed to create a common xsl template file and separate files controlling output namespace and validation.
Testing EAD2002ToEAD3dtd.xsl against set of 2329 dtd valid EAD 2002 instances. Errors mostly in source. Probably ready to merge to master. valid: 1666 (71.53%) Errors:
|
Looks good to me. Not sure what we could have done about any of those errors. Are you looking at the other style sheets? |
Yes, I'm testing the schema one now. Many more problems there for some /Terry On Wed, Jul 20, 2016 at 8:17 AM, Michael Rush [email protected]
|
Testing EAD2002ToEAD3schema against 1412 EAD 2002 schema valid instances XSD using Xerces in oXygen 18 (Linux): 1404 valid (99.4%) [XSD includeds ID/IDREF checking]
RelaxNG using jing in oXygen 18 (Linux) 1405 valid (99.5%) [RelaxNG does not peform ID/IDREF checking by default]
|
The results of the testing were very good. Most errors were either errors in the source or result of outlier practice (e.g., note as footnote inside note in did). One caveat is that the testbed was the same as the last time the conversion was tested. Testing against another randomly selected testbed might reveal previously undetected bugs. |
Another caveat is that I havent tested the XSD validation using libxml2 due to the known bug in the definintion of objectxmlwrap. While I think this is a libxml problem rather than an EAD3 problem, it should be fixed since the libxml2 library is used by languages like Ruby (e.g., nokogiri) and Python (lxml, xml.etree). |
@rockivist https://github.com/rockivist: should I find EAD2002 instances On Wed, Jul 20, 2016 at 10:44 AM, Terry Catapano [email protected]
|
@tcatapano Just use the existing testbed. I want to make sure the schema and namespace stuff works and get it out. Easier to tweak the undeprecated-specific migration stuff later if we get bug reports. |
Ok. Should definitely have this done by the end of the week. On Jul 26, 2016 6:44 PM, "Michael Rush" [email protected] wrote:
|
Fixes problems identified during testing for #52 including physfacet attributes, unittitle/unitdate migration, and imprint/publisher migration.
@tcatapano I just made some fixes to address the issues you found with the undeprecated migration style sheets. In particular, I fixed the problems related to physfacet attributes, imprint/publisher, and unittitle/unitdate. I did not fix the issues related to bibref. I logged that issue in #50, not sure what can be done. It's not a problem with the schema, just the migration. But it's sufficiently complicated to unravel that I can live with it as is, at least until we hear from people that it's a serious issue. If my fixes pass muster with another test, I'm happy to roll up to master. |
@rockivist https://github.com/rockivist OK. I'll re-run the test of the On Sat, Jul 30, 2016 at 12:27 AM, Michael Rush [email protected]
|
Testing EAD2002ToEAD3dtd_undeprecated.xsl 927 instances using xerces in oXygen 18 on Ubuntu 14.04
|
@rockivist: current test of undeprecated dtd stylesheet reveals a probable error in the content model of descgrp. Im going to check against the rng and xsd to see if there's a problem there as well. |
@rockivist: looks like the problem is only with the undeprecated DTD. Must have been some problem with the conversion from RNG to DTD by trang. I'll log an issue on the EAD3 repo. |
@rockivist Nevermind, you already reported the bug (SAA-SDT/EAD3#503) in the EAD3 repo |
testing revised EAD2002ToEAD3schema_undeprecated.xsl on 650 EAD2002 valid instances using xerces in oXygen 18 on ubuntu 14.04:
|
@rockivist: xsd/rng converter give the same errors, none of which is a bug. Given that, aside from the DTD bug, the DTD stylesheet seems to also have no bugs, I'd say we're ready to merge. Do you agree? |
Absolutely! Go for it! |
@tcatapano Thanks! Will you put together a new release? As soon as that is done I'll post an announcement. |
@rockivist: draft release has been prepared. Take a look before it is On Mon, Aug 1, 2016 at 5:09 PM, Michael Rush [email protected]
|
@tcatapano I added a link to issues since a few are known. Otherwise it looks good. Will you keep this pre-release or will this graduate out of beta? I'm happy to make it a full release since I think it's about as good as its going to get. |
@rockivist: I was going to go ahead and make this 1.0.0. Just released it: https://github.com/SAA-SDT/EAD2002toEAD3/releases/tag/v1.0.0 Congrats! /Terry On Mon, Aug 1, 2016 at 8:21 PM, Michael Rush [email protected]
|
@tcatapano Awesome! Thanks so much. A drink to celebrate sometime soon is necessary. |
@tcatapano I've done a fair amount of work to address issues #48, #51, #20, and #40.
Can you look over my changes, test them yourself, and if they past muster, merge them into the master branch and create a new release?
As you'll see I've broken out schema-valid migration from dtd-valid migration, as well as breaking out undeprecated migration. So there are now four different version of the migration style sheet.
Now that we are handling DTD migration separately, would it be possible for you to look into #32? The other remaining open issues are likely to remain so as documentation. I don't think there's anything to be done about them. But I suspect you may be able to address the entity migration.
Let me know if you want to chat about this. No particular deadline, but if you have time, I'd appreciate your assistance. As far as I'm concerned this closes my book on EAD3.
Mike