Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge updates on develop into master #52

Merged
merged 22 commits into from
Aug 1, 2016
Merged

Merge updates on develop into master #52

merged 22 commits into from
Aug 1, 2016

Conversation

rockivist
Copy link
Member

@tcatapano I've done a fair amount of work to address issues #48, #51, #20, and #40.

Can you look over my changes, test them yourself, and if they past muster, merge them into the master branch and create a new release?

As you'll see I've broken out schema-valid migration from dtd-valid migration, as well as breaking out undeprecated migration. So there are now four different version of the migration style sheet.

Now that we are handling DTD migration separately, would it be possible for you to look into #32? The other remaining open issues are likely to remain so as documentation. I don't think there's anything to be done about them. But I suspect you may be able to address the entity migration.

Let me know if you want to chat about this. No particular deadline, but if you have time, I'd appreciate your assistance. As far as I'm concerned this closes my book on EAD3.

Mike

Update develop from master
Added xsl:choose to xlink stripping template so that href values aren't
converted to lowercase
To enable user to pass param indicating if they want their output to
validate against dtd,, rng, or xsd.
Added new params to list. Related to #40
Needed to create a common xsl template file and separate files
controlling output namespace and validation.
Updated migration of descgrp/address in all migration style sheets.
Reflects changes for #40, #20
Fixes small error in oxygen-specific PI
@tcatapano
Copy link
Member

Testing EAD2002ToEAD3dtd.xsl against set of 2329 dtd valid EAD 2002 instances. Errors mostly in source. Probably ready to merge to master.

valid: 1666 (71.53%)
invalid: 663 (28.46%)

Errors:

  • 611 Value "iso639-2" for attribute langencoding of control is not among the enumerated set [Data error]
  • 107 Element scopecontent content does not follow the DTD, expecting (head? , (chronlist | list | table | blockquote | p | scopecontent)+), got () [removal of dao leaves scopecontent empty]
  • 32 Syntax of value for attribute certainty of unitdate is not valid [value is null]
  • 10 Element controlaccess content does not follow the DTD, expecting (head? , (chronlist | list | table | blockquote | p | persname | corpname | famname | geogname | name | occupation | subject | genreform | function | title | controlaccess)+), got () [empty controlaccess in source]
  • 7 Element title is not declared in physdesc list of possible children [unusual encoding in source]
  • 6 Element origination content does not follow the DTD, expecting (corpname | famname | name | persname)+, got () [no *name elements in source; addressed by comment " PORTIONS NOT INCLUDED IN persname, corpname, famname, OR name ELEMENTS WERE LOST."]
  • 3 Value "iso3166-a" for attribute countryencoding of control is not among the enumerated set [data error]
  • 2 Element indexentry content does not follow the DTD, expecting ((namegrp | persname | corpname | famname | geogname | name | occupation | subject | genreform | function | title) , (ptrgrp | ptr | ref)? , indexentry*), got (ptr ) [indexentry elements with no content; problem from template]
  • 1 Value "iso_639" for attribute langencoding of control is not among the enumerated set [data error]
  • 1 Value "iso6392-b" for attribute langencoding of control is not among the enumerated set [data_error]
  • 1 Value "iso155511" for attribute repositoryencoding of control is not among the enumerated set [data error]
  • 1 Syntax of value for attribute certainty of date is not valid [not in source]
  • 1 Element did content does not follow the DTD, expecting (head? , (abstract | container | dao | daoset | didnote | langmaterial | materialspec | origination | physdescset | physdesc | physdescstructured | physloc | repository | unitdate | unitdatestructured | unitid | unittitle)+), got [did with note only, now empty after move to odd ]

@rockivist
Copy link
Member Author

Looks good to me. Not sure what we could have done about any of those errors.

Are you looking at the other style sheets?

@tcatapano
Copy link
Member

Yes, I'm testing the schema one now. Many more problems there for some
reason... After that the undeprecated stylesheets.

/Terry

On Wed, Jul 20, 2016 at 8:17 AM, Michael Rush [email protected]
wrote:

Looks good to me. Not sure what we could have done about any of those
errors.

Are you looking at the other style sheets?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7A8pkCyLTdvI-mwNK5eIQCCFdjmi7Hks5qXhHagaJpZM4I8a_2
.

@tcatapano
Copy link
Member

Testing EAD2002ToEAD3schema against 1412 EAD 2002 schema valid instances

XSD using Xerces in oXygen 18 (Linux):

1404 valid (99.4%)
8 invalid (.006%)

[XSD includeds ID/IDREF checking]

  • 3 Description: cvc-complex-type.2.4.b: The content of element 'did' is not complete. One of '{"http://ead3.archivists.org/schema/":head, "http://ead3.archivists.org/schema/":abstract, "http://ead3.archivists.org/schema/":container, "http://ead3.archivists.org/schema/":dao, "http://ead3.archivists.org/schema/":daoset, "http://ead3.archivists.org/schema/":didnote, "http://ead3.archivists.org/schema/":langmaterial, "http://ead3.archivists.org/schema/":materialspec, "http://ead3.archivists.org/schema/":origination, "http://ead3.archivists.org/schema/":physdescset, "http://ead3.archivists.org/schema/":physdesc, "http://ead3.archivists.org/schema/":physdescstructured, "http://ead3.archivists.org/schema/":physloc, "http://ead3.archivists.org/schema/":repository, "http://ead3.archivists.org/schema/":unitdate, "http://ead3.archivists.org/schema/":unitdatestructured, "http://ead3.archivists.org/schema/":unitid, "http://ead3.archivists.org/schema/":unittitle}' is expected. [note removed from did leaves did empty]
  •   2 Description: cvc-enumeration-valid: Value 'iso939' is not facet-valid with respect to enumeration '[iso639-1, iso639-2b, iso639-3, otherlangencoding]'. It must be a value from the enumeration. [data error]
    
  •   2 Description: cvc-attribute.3: The value 'iso939' of attribute 'langencoding' on element 'control' is not valid with respect to its type, '#AnonType_langencodingcontrol'. _[data error]_
    
  •   1 Description: cvc-id.1: There is no ID/IDREF binding for IDREF 'reprintsa2'. _[target element removed (extent)]_
    
  •   1 Description: cvc-id.1: There is no ID/IDREF binding for IDREF 'manuscriptsa1'. _[target element removed (extent)]_
    
  •   1 Description: cvc-id.1: There is no ID/IDREF binding for IDREF 'B1'. _[target element removed (extent)]_
    
  •   1 Description: cvc-id.1: There is no ID/IDREF binding for IDREF 'A1'. _[target element removed (extent)]_
    
  •   1 Description: cvc-complex-type.2.4.b: The content of element 'did' is not complete. One of '{"http://ead3.archivists.org/schema/":abstract, "http://ead3.archivists.org/schema/":container, "http://ead3.archivists.org/schema/":dao, "http://ead3.archivists.org/schema/":daoset, "http://ead3.archivists.org/schema/":didnote, "http://ead3.archivists.org/schema/":langmaterial, "http://ead3.archivists.org/schema/":materialspec, "http://ead3.archivists.org/schema/":origination, "http://ead3.archivists.org/schema/":physdescset, "http://ead3.archivists.org/schema/":physdesc, "http://ead3.archivists.org/schema/":physdescstructured, "http://ead3.archivists.org/schema/":physloc, "http://ead3.archivists.org/schema/":repository, "http://ead3.archivists.org/schema/":unitdate, "http://ead3.archivists.org/schema/":unitdatestructured, "http://ead3.archivists.org/schema/":unitid, "http://ead3.archivists.org/schema/":unittitle}' is expected. _[note removed from did leaves did with only head]_
    
  •   1 Description: cvc-complex-type.2.4.a: Invalid content was found starting with element '{"http://ead3.archivists.org/schema/":ref}'. One of '{"http://ead3.archivists.org/schema/":abbr, "http://ead3.archivists.org/schema/":expan, "http://ead3.archivists.org/schema/":emph, "http://ead3.archivists.org/schema/":lb, "http://ead3.archivists.org/schema/":ptr, "http://ead3.archivists.org/schema/":quote, "http://ead3.archivists.org/schema/":num, "http://ead3.archivists.org/schema/":footnote, "http://ead3.archivists.org/schema/":date, "http://ead3.archivists.org/schema/":persname, "http://ead3.archivists.org/schema/":corpname, "http://ead3.archivists.org/schema/":famname, "http://ead3.archivists.org/schema/":geogname, "http://ead3.archivists.org/schema/":name, "http://ead3.archivists.org/schema/":occupation, "http://ead3.archivists.org/schema/":subject, "http://ead3.archivists.org/schema/":genreform, "http://ead3.archivists.org/schema/":function, "http://ead3.archivists.org/schema/":title}' is expected. _[archref in p converted to ref, not valid as only child of p?]_
    
  •   1 Description: cvc-complex-type.2.4.a: Invalid content was found starting with element '{"http://ead3.archivists.org/schema/":footnote}'. One of '{"http://ead3.archivists.org/schema/":abbr, "http://ead3.archivists.org/schema/":emph, "http://ead3.archivists.org/schema/":expan, "http://ead3.archivists.org/schema/":foreign, "http://ead3.archivists.org/schema/":lb, "http://ead3.archivists.org/schema/":ptr, "http://ead3.archivists.org/schema/":ref}' is expected. _[note inside didnote converted to footnote]_
    

RelaxNG using jing in oXygen 18 (Linux)

1405 valid (99.5%)
7 invalid (.005%)

[RelaxNG does not peform ID/IDREF checking by default]

  • 3 Description: element "did" incomplete; expected element "abstract", "container", "dao", "daoset", "didnote", "head", "langmaterial", "materialspec", "origination", "physdesc", "physdescset", "physdescstructured", "physloc", "repository", "unitdate", "unitdatestructured", "unitid" or "unittitle" [note removed from did leaves did empty]
  •   2 Description: value of attribute "langencoding" is invalid; must be equal to "iso639-1", "iso639-2b", "iso639-3" or "otherlangencoding" _[data error]_
    
  •   1 Description: element "ref" not allowed here; expected the element end-tag, text or element "abbr", "corpname", "date", "emph", "expan", "famname", "footnote", "function", "genreform", "geogname", "lb", "name", "num", "occupation", "persname", "ptr", "quote", "subject" or "title"  _[archref in p converted to ref, not valid as only child of p?]_
    
  •   1 Description: element "footnote" not allowed here; expected the element end-tag, text or element "abbr", "emph", "expan", "foreign", "lb", "ptr" or "ref" _[note inside didnote converted to footnote]_
    
  •   1 Description: element "did" incomplete; expected element "abstract", "container", "dao", "daoset", "didnote", "langmaterial", "materialspec", "origination", "physdesc", "physdescset", "physdescstructured", "physloc", "repository", "unitdate", "unitdatestructured", "unitid" or "unittitle" _[note removed from did leaves did with only head]_
    

@tcatapano
Copy link
Member

tcatapano commented Jul 20, 2016

The results of the testing were very good. Most errors were either errors in the source or result of outlier practice (e.g., note as footnote inside note in did). One caveat is that the testbed was the same as the last time the conversion was tested. Testing against another randomly selected testbed might reveal previously undetected bugs.

@tcatapano
Copy link
Member

Another caveat is that I havent tested the XSD validation using libxml2 due to the known bug in the definintion of objectxmlwrap. While I think this is a libxml problem rather than an EAD3 problem, it should be fixed since the libxml2 library is used by languages like Ruby (e.g., nokogiri) and Python (lxml, xml.etree).

@tcatapano
Copy link
Member

@rockivist https://github.com/rockivist: should I find EAD2002 instances
with deprecated features to test the undeprecated stylesheets or should I
just test against the existing testbeds. The former will take much more
time.

On Wed, Jul 20, 2016 at 10:44 AM, Terry Catapano [email protected]
wrote:

Yes, I'm testing the schema one now. Many more problems there for some
reason... After that the undeprecated stylesheets.

/Terry

On Wed, Jul 20, 2016 at 8:17 AM, Michael Rush [email protected]
wrote:

Looks good to me. Not sure what we could have done about any of those
errors.

Are you looking at the other style sheets?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7A8pkCyLTdvI-mwNK5eIQCCFdjmi7Hks5qXhHagaJpZM4I8a_2
.

@rockivist
Copy link
Member Author

@tcatapano Just use the existing testbed. I want to make sure the schema and namespace stuff works and get it out. Easier to tweak the undeprecated-specific migration stuff later if we get bug reports.

@tcatapano
Copy link
Member

Ok. Should definitely have this done by the end of the week.

On Jul 26, 2016 6:44 PM, "Michael Rush" [email protected] wrote:

@tcatapano https://github.com/tcatapano Just use the existing testbed.
I want to make sure the schema and namespace stuff works and get it out.
Easier to tweak the undeprecated-specific migration stuff later if we get
bug reports.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7A8tTIzt2kZD6RPlrobY3ctGTIMyNgks5qZo22gaJpZM4I8a_2
.

@tcatapano
Copy link
Member

tcatapano commented Jul 28, 2016

Testing EAD2002ToEAD3schema_undeprecated.xsl against schema-valid testbed (650 files)
(using xerces in oXygen 18 Ubuntu 14.04)

Fixes problems identified during testing for #52 including physfacet
attributes, unittitle/unitdate migration, and imprint/publisher
migration.
@rockivist
Copy link
Member Author

@tcatapano I just made some fixes to address the issues you found with the undeprecated migration style sheets. In particular, I fixed the problems related to physfacet attributes, imprint/publisher, and unittitle/unitdate. I did not fix the issues related to bibref. I logged that issue in #50, not sure what can be done. It's not a problem with the schema, just the migration. But it's sufficiently complicated to unravel that I can live with it as is, at least until we hear from people that it's a serious issue.

If my fixes pass muster with another test, I'm happy to roll up to master.

@tcatapano
Copy link
Member

@rockivist https://github.com/rockivist OK. I'll re-run the test of the
XSD/RNG undeprecated stylesheets. I also am in the midst of testing the DTD
valid undeprecated instances. Takes longer because it's a larger sample
size. Hope to have this done on Monday.

On Sat, Jul 30, 2016 at 12:27 AM, Michael Rush [email protected]
wrote:

@tcatapano https://github.com/tcatapano I just made some fixes to
address the issues you found with the undeprecated migration style sheets.
In particular, I fixed the problems related to physfacet attributes,
imprint/publisher, and unittitle/unitdate. I did not fix the issues related
to bibref. I logged that issue in #50
#50, not sure what can
be done. It's not a problem with the schema, just the migration. But it's
sufficiently complicated to unravel that I can live with it as is, at least
until we hear from people that it's a serious issue.

If my fixes pass muster with another test, I'm happy to roll up to master.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7A8inHlnqCnRHmaiJg0y5zlMO-M_T-ks5qatKcgaJpZM4I8a_2
.

@tcatapano
Copy link
Member

tcatapano commented Aug 1, 2016

Testing EAD2002ToEAD3dtd_undeprecated.xsl 927 instances using xerces in oXygen 18 on Ubuntu 14.04

  • 185 Description: Unexpected element "accessrestrict". The content of the parent element type must match "(head?,((chronlist|list|table|blockquote|p),(accessrestrict|accruals|acqinfo|altformavail|appraisal|arrangement|bibliography|bioghist|controlaccess|custodhist|descgrp|fileplan|index|legalstatus|odd|originalsloc|otherfindaid|phystech|prefercite|processinfo|relatedmaterial|relations|scopecontent|separatedmaterial|userestrict))+)". _[looks like a DTD/schema error]_
    
  • 108 Description: Attribute "langencoding" with value "iso639-2" must have a value from the list "iso639-1 iso639-2b iso639-3 otherlangencoding ". _[data error]_
    
  • 106 Description: Unexpected element "prefercite". The content of the parent element type must match "(head?,((chronlist|list|table|blockquote|p),(accessrestrict|accruals|acqinfo|altformavail|appraisal|arrangement|bibliography|bioghist|controlaccess|custodhist|descgrp|fileplan|index|legalstatus|odd|originalsloc|otherfindaid|phystech|prefercite|processinfo|relatedmaterial|relations|scopecontent|separatedmaterial|userestrict))+)". _[looks like a DTD/schema error]_
    
  •  31 Description: Unexpected element "acqinfo". The content of the parent element type must match "(head?,((chronlist|list|table|blockquote|p), (accessrestrict|accruals|acqinfo|altformavail|appraisal|arrangement|bibliography|bioghist|controlaccess|custodhist|descgrp|fileplan|index|legalstatus|odd|originalsloc|otherfindaid|phystech|prefercite|processinfo|relatedmaterial|relations|scopecontent|separatedmaterial|userestrict))+)". _[looks like a DTD/schema error]_
    
  •  12 Description: Attribute value "" of type NMTOKEN must be a name token. _[error introduced by newer, stricter attribute models]_
    
  •   9 Description: Unexpected element "userestrict". The content of the parent element type must match "(head?,((chronlist|list|table|blockquote|p),(accessrestrict|accruals|acqinfo|altformavail|appraisal|arrangement|bibliography|bioghist|controlaccess|custodhist|descgrp|fileplan|index|legalstatus|odd|originalsloc|otherfindaid|phystech|prefercite|processinfo|relatedmaterial|relations|scopecontent|separatedmaterial|userestrict))+)". _[looks like a DTD/schema error]_
    
  •   7 Description: The content of element type "controlaccess" is incomplete, it must match "(head?,(chronlist|list|table|blockquote|p|persname|corpname|famname|geogname|name|occupation|subject|genreform|function|title|controlaccess)+)". _[data error; source has no content only template PI]_
    
  •   6 Description: Unexpected element "ref". The content of the parent element type must match "(abbr|expan|emph|lb|ptr|quote|num|footnote|date|persname|corpname|famname|geogname|name|occupation|subject|genreform|function|title)". _[ref inside ref from converted bibref]_
    
  •   4 Description: Unexpected element "scopecontent". The content of the parent element type must match "(head?,((chronlist|list|table|blockquote|p),(accessrestrict|accruals|acqinfo|altformavail|appraisal|arrangement|bibliography|bioghist|controlaccess|custodhist|descgrp|fileplan|index|legalstatus|odd|originalsloc|otherfindaid|phystech|prefercite|processinfo|relatedmaterial|relations|scopecontent|separatedmaterial|userestrict))+)". _[looks like a DTD/schema error]_
    
  •   4 Description: Unexpected element "relatedmaterial". The content of the parent element type must match "(head?,((chronlist|list|table|blockquote|p), (accessrestrict|accruals|acqinfo|altformavail|appraisal|arrangement|bibliography|bioghist|controlaccess|custodhist|descgrp|fileplan|index|legalstatus|odd|originalsloc|otherfindaid|phystech|prefercite|processinfo|relatedmaterial|relations|scopecontent|separatedmaterial|userestrict))+)". _[looks like a DTD/schema error]_
    
  •   4 Description: Unexpected element "imprint". The content of the parent element type must match "(abbr|emph|expan|foreign|lb|ptr|ref|persname|corpname|famname|geogname|name|occupation|subject|genreform|function|title|date|footnote|num|quote)". _[known issue]_
    
  •   4 Description: Unexpected element "bioghist". The content of the parent element type must match "(head?,((chronlist|list|table|blockquote|p),(accessrestrict|accruals|acqinfo|altformavail|appraisal|arrangement|bibliography|bioghist|controlaccess|custodhist|descgrp|fileplan|index|legalstatus|odd|originalsloc|otherfindaid|phystech|prefercite|processinfo|relatedmaterial|relations|scopecontent|separatedmaterial|userestrict))+)". _[looks like a DTD/schema error]_
    
  •   4 Description: Unexpected element "bibliography". The content of the parent element type must match "(head?,((chronlist|list|table|blockquote|p),(accessrestrict|accruals|acqinfo|altformavail|appraisal|arrangement|bibliography|bioghist|controlaccess|custodhist|descgrp|fileplan|index|legalstatus|odd|originalsloc|otherfindaid|phystech|prefercite|processinfo|relatedmaterial|relations|scopecontent|separatedmaterial|userestrict))+)". _[looks like a DTD/schema error]_
    
  •   4 Description: Unexpected element "altformavail". The content of the parent element type must match "(head?,((chronlist|list|table|blockquote|p),(accessrestrict|accruals|acqinfo|altformavail|appraisal|arrangement|bibliography|bioghist|controlaccess|custodhist|descgrp|fileplan|index|legalstatus|odd|originalsloc|otherfindaid|phystech|prefercite|processinfo|relatedmaterial|relations|scopecontent|separatedmaterial|userestrict))+)". _[looks like a DTD/schema error]_
    
  •   3 Description: Unexpected element "imprint". The content of the parent element type must match "(abbr|expan|emph|lb|ptr|quote|num|footnote|date|persname|corpname|famname|geogname|name|occupation|subject|genreform|function|title)". _[known issue]_
    
  •   2 Description: Unexpected element "ref". The content of the parent element type must match "((namegrp|persname|corpname|famname|geogname|name|occupation|subject|genreform|function|title),(ptrgrp|ptr|ref)?,indexentry*)". _[data error. no content as source has only template PI]_
    
  •   2 Description: Attribute "countryencoding" with value "us" must have a value from the list "iso3166-1 othercountryencoding ". _[data error]_
    
  •   1 Description: Attribute value "1972/1974" of type NMTOKEN must be a name token. _[error introduced by newer, stricter attribute models]_
    
  •   1 Description: Attribute value "1966/1970" of type NMTOKEN must be a name token. _[error introduced by newer, stricter attribute models]_
    
  •   1 Description: Attribute "scriptencoding" with value "iso-15924" must have a value from the list "iso15924 otherscriptencoding ". _[data error]_
    
  •    1 Description: Attribute "langencoding" with value "iso6392b" must have a value from the list "iso639-1 iso639-2b iso639-3 otherlangencoding ". _[data error]_
    
  •   1 Description: Attribute "langencoding" with value "iso-639-2b" must have a value from the list "iso639-1 iso639-2b iso639-3 otherlangencoding ". _[data error]_
    
  •   1 Description: Attribute "actuate" with value "actuatenone" must have a value from the list "onload onrequest other none ". _[data error]_
    

@tcatapano
Copy link
Member

@rockivist: current test of undeprecated dtd stylesheet reveals a probable error in the content model of descgrp. Im going to check against the rng and xsd to see if there's a problem there as well.

@tcatapano
Copy link
Member

@rockivist: looks like the problem is only with the undeprecated DTD. Must have been some problem with the conversion from RNG to DTD by trang. I'll log an issue on the EAD3 repo.

@tcatapano
Copy link
Member

tcatapano commented Aug 1, 2016

@rockivist Nevermind, you already reported the bug (SAA-SDT/EAD3#503) in the EAD3 repo

@tcatapano
Copy link
Member

testing revised EAD2002ToEAD3schema_undeprecated.xsl on 650 EAD2002 valid instances using xerces in oXygen 18 on ubuntu 14.04:

  • 17 Description: cvc-complex-type.2.4.a: Invalid content was found starting with element '{"http://ead3.archivists.org/schema/undeprecated/":imprint}'. One of '{"http://ead3.archivists.org/schema/undeprecated/":abbr, "http://ead3.archivists.org/schema/undeprecated/":expan, "http://ead3.archivists.org/schema/undeprecated/":emph, "http://ead3.archivists.org/schema/undeprecated/":lb, "http://ead3.archivists.org/schema/undeprecated/":ptr, "http://ead3.archivists.org/schema/undeprecated/":quote, "http://ead3.archivists.org/schema/undeprecated/":num, "http://ead3.archivists.org/schema/undeprecated/":footnote, "http://ead3.archivists.org/schema/undeprecated/":date, "http://ead3.archivists.org/schema/undeprecated/":persname, "http://ead3.archivists.org/schema/undeprecated/":corpname, "http://ead3.archivists.org/schema/undeprecated/":famname, "http://ead3.archivists.org/schema/undeprecated/":geogname, "http://ead3.archivists.org/schema/undeprecated/":name, "http://ead3.archivists.org/schema/undeprecated/":occupation, "http://ead3.archivists.org/schema/undeprecated/":subject, "http://ead3.archivists.org/schema/undeprecated/":genreform, "http://ead3.archivists.org/schema/undeprecated/":function, "http://ead3.archivists.org/schema/undeprecated/":title}' is expected. [known issue: imprint not valid as child of ref]
  •   3 Description: cvc-complex-type.2.4.a: Invalid content was found starting with element '{"http://ead3.archivists.org/schema/undeprecated/":bibseries}'. One of '{"http://ead3.archivists.org/schema/undeprecated/":abbr, "http://ead3.archivists.org/schema/undeprecated/":expan, "http://ead3.archivists.org/schema/undeprecated/":emph, "http://ead3.archivists.org/schema/undeprecated/":lb, "http://ead3.archivists.org/schema/undeprecated/":ptr, "http://ead3.archivists.org/schema/undeprecated/":quote, "http://ead3.archivists.org/schema/undeprecated/":num, "http://ead3.archivists.org/schema/undeprecated/":footnote, "http://ead3.archivists.org/schema/undeprecated/":date, "http://ead3.archivists.org/schema/undeprecated/":persname, "http://ead3.archivists.org/schema/undeprecated/":corpname, "http://ead3.archivists.org/schema/undeprecated/":famname, "http://ead3.archivists.org/schema/undeprecated/":geogname, "http://ead3.archivists.org/schema/undeprecated/":name, "http://ead3.archivists.org/schema/undeprecated/":occupation, "http://ead3.archivists.org/schema/undeprecated/":subject, "http://ead3.archivists.org/schema/undeprecated/":genreform, "http://ead3.archivists.org/schema/undeprecated/":function, "http://ead3.archivists.org/schema/undeprecated/":title}' is expected._[known issue: bibseries not valid as child of ref]_
    
  •   2 Description: cvc-complex-type.2.4.a: Invalid content was found starting with element '{"http://ead3.archivists.org/schema/undeprecated/":ref}'. One of '{"http://ead3.archivists.org/schema/undeprecated/":abbr, "http://ead3.archivists.org/schema/undeprecated/":expan, "http://ead3.archivists.org/schema/undeprecated/":emph, "http://ead3.archivists.org/schema/undeprecated/":lb, "http://ead3.archivists.org/schema/undeprecated/":ptr, "http://ead3.archivists.org/schema/undeprecated/":quote, "http://ead3.archivists.org/schema/undeprecated/":num, "http://ead3.archivists.org/schema/undeprecated/":footnote, "http://ead3.archivists.org/schema/undeprecated/":date, "http://ead3.archivists.org/schema/undeprecated/":persname, "http://ead3.archivists.org/schema/undeprecated/":corpname, "http://ead3.archivists.org/schema/undeprecated/":famname, "http://ead3.archivists.org/schema/undeprecated/":geogname, "http://ead3.archivists.org/schema/undeprecated/":name, "http://ead3.archivists.org/schema/undeprecated/":occupation, "http://ead3.archivists.org/schema/undeprecated/":subject, "http://ead3.archivists.org/schema/undeprecated/":genreform, "http://ead3.archivists.org/schema/undeprecated/":function, "http://ead3.archivists.org/schema/undeprecated/":title}' is expected. _[known issue: ref not valid as child of ref]_
    
  •   1 Description: cvc-enumeration-valid: Value 'iso939' is not facet-valid with respect to enumeration '[iso639-1, iso639-2b, iso639-3, otherlangencoding]'. It must be a value from the enumeration. _[data error]_
    
  •   1 Description: cvc-complex-type.2.4.b: The content of element 'did' is not complete. One of '{"http://ead3.archivists.org/schema/undeprecated/":head, "http://ead3.archivists.org/schema/undeprecated/":abstract, "http://ead3.archivists.org/schema/undeprecated/":container, "http://ead3.archivists.org/schema/undeprecated/":dao, "http://ead3.archivists.org/schema/undeprecated/":daoset, "http://ead3.archivists.org/schema/undeprecated/":didnote, "http://ead3.archivists.org/schema/undeprecated/":langmaterial, "http://ead3.archivists.org/schema/undeprecated/":materialspec, "http://ead3.archivists.org/schema/undeprecated/":origination, "http://ead3.archivists.org/schema/undeprecated/":physdescset, "http://ead3.archivists.org/schema/undeprecated/":physdesc, "http://ead3.archivists.org/schema/undeprecated/":physdescstructured, "http://ead3.archivists.org/schema/undeprecated/":physloc, "http://ead3.archivists.org/schema/undeprecated/":repository, "http://ead3.archivists.org/schema/undeprecated/":unitdate, "http://ead3.archivists.org/schema/undeprecated/":unitdatestructured, "http://ead3.archivists.org/schema/undeprecated/":unitid, "http://ead3.archivists.org/schema/undeprecated/":unittitle}' is expected. _[note moved to odd leaves empty did]_
    
  •   1 Description: cvc-attribute.3: The value 'iso939' of attribute 'langencoding' on element 'control' is not valid with respect to its type, '#AnonType_langencodingcontrol'. _[data error]_
    

@tcatapano
Copy link
Member

@rockivist: xsd/rng converter give the same errors, none of which is a bug. Given that, aside from the DTD bug, the DTD stylesheet seems to also have no bugs, I'd say we're ready to merge. Do you agree?

@rockivist
Copy link
Member Author

Absolutely! Go for it!

@tcatapano tcatapano merged commit f3546db into master Aug 1, 2016
@rockivist
Copy link
Member Author

@tcatapano Thanks! Will you put together a new release? As soon as that is done I'll post an announcement.

@tcatapano
Copy link
Member

@rockivist: draft release has been prepared. Take a look before it is
published.
https://github.com/SAA-SDT/EAD2002toEAD3/releases/tag/untagged-cdbae7f61f8614016083

On Mon, Aug 1, 2016 at 5:09 PM, Michael Rush [email protected]
wrote:

@tcatapano https://github.com/tcatapano Thanks! Will you put together a
new release? As soon as that is done I'll post an announcement.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7A8qUjNCh2p8ytlDriTLbXrtHiJKFvks5qbmCFgaJpZM4I8a_2
.

@rockivist
Copy link
Member Author

@tcatapano I added a link to issues since a few are known. Otherwise it looks good. Will you keep this pre-release or will this graduate out of beta? I'm happy to make it a full release since I think it's about as good as its going to get.

@tcatapano
Copy link
Member

@rockivist: I was going to go ahead and make this 1.0.0. Just released it:

https://github.com/SAA-SDT/EAD2002toEAD3/releases/tag/v1.0.0

Congrats!

/Terry

On Mon, Aug 1, 2016 at 8:21 PM, Michael Rush [email protected]
wrote:

@tcatapano https://github.com/tcatapano I added a link to issues since
a few are known. Otherwise it looks good. Will you keep this pre-release or
will this graduate out of beta? I'm happy to make it a full release since I
think it's about as good as its going to get.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7A8oEuSHX68Hv2YyAO8jntShz5VSMoks5qbo2cgaJpZM4I8a_2
.

@rockivist
Copy link
Member Author

@tcatapano Awesome! Thanks so much. A drink to celebrate sometime soon is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants