-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IssueInstant check #397
base: master
Are you sure you want to change the base?
IssueInstant check #397
Conversation
Tests are passing => https://travis-ci.org/onelogin/php-saml/builds/593893031 |
5a7a06d
to
c06041b
Compare
This feature adds a lot of complexity to the toolkit (new settings and new methods for a lot of methods). If you want to force that an AuthNRequest or a LogoutRequest has a reply in X time, I think you can do that at a high level, just saving the IDs of the request and timestamp and rejecting "expired" responses. As far as a understand, SAML does not define a valid time between requests and responses. Also, take in mind that some authentication process with 2FA and biometrics process can take time, so not sure about the convenience of this kind of restriction. |
Hi @pitbulk, the new check is not about the time between the request and the subsequent response, but for ensuring that the issue instant of the response in not earlier than the one the request. Summary of changes:
|
This PR adds support for a strict check about IssueInstant attributes in the requests and the subsequent responses. An accepted clock skew is configurable with the new
clockSkewTolerance
setting.All the changes are backward compatible as the IssueInstant check is an opt-in feature.
All the changes are tested and docs updated accordingly.