Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add artifact binding for ACS #237

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Add artifact binding for ACS #237

wants to merge 26 commits into from

Commits on Jan 14, 2021

  1. Add basic support for the SAML2 Artifact Binding.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    38d559d View commit details
    Browse the repository at this point in the history

  2. Add basic support for the metadata parser to parse the artifactResolu… 

    …tionService
    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    d9fb072 View commit details
    Browse the repository at this point in the history

  3. Oops, I reversed the certs/key options for Requests.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    3b57911 View commit details
    Browse the repository at this point in the history

  4. Add signing to the ArtifactResolve message. It looks like it is requi… 

    …red for Digi-ID.
    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    34c084d View commit details
    Browse the repository at this point in the history

  5. Add logging for requests.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    68ecd46 View commit details
    Browse the repository at this point in the history

  6. Oops, use the proper error message

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    a1140a3 View commit details
    Browse the repository at this point in the history

  7. Undo the 'check_signatures' hack I introduced earlier.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    88ff692 View commit details
    Browse the repository at this point in the history

  8. The metadataparser now sets artifactResolutionService. Adapt the test… 

    …s accordingly.
    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    4acbf90 View commit details
    Browse the repository at this point in the history

  9. Load the soap SSL/TLS key from the security setting instead.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    9c25d05 View commit details
    Browse the repository at this point in the history

  10. Cleanup

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    aec78a2 View commit details
    Browse the repository at this point in the history

  11. Ignore the Advice section when looking for signatures.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    8047805 View commit details
    Browse the repository at this point in the history

  12. Refactor the way the SAML Artifact are processed. In the previous setup 

    I used 1 artifactResolutionService (the first) and it was parsed from
the metadata file. However, in the metadata file I am using, the same
URL is used, with two different indexes. Since the wrong index was
returned, this caused errors.

Another implementation would be to just ignore the index/url returned
in the SAML artifact.
    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    41f7cf2 View commit details
    Browse the repository at this point in the history

  13. Onelogin's XML to string method messes up the XML, making the signatu… 

    …re invalid.
    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    3391a69 View commit details
    Browse the repository at this point in the history

  14. Make sure the error code is passed on, when validation error is re-ra… 

    …ised.
    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    db856a7 View commit details
    Browse the repository at this point in the history

  15. Use defusedxml instead of lxml directly.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    e5664d7 View commit details
    Browse the repository at this point in the history

  16. Add requests as a dependency.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    1809527 View commit details
    Browse the repository at this point in the history

  17. Various small documentation/text fixes I noticed going through the code.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    0fe4fe5 View commit details
    Browse the repository at this point in the history

  18. Allow the user to distinguish between technical errors and AuthnFailed.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    2bbccc8 View commit details
    Browse the repository at this point in the history

  19. Make sure the status code of the ArtifactResponse is checked as well.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    76e88d4 View commit details
    Browse the repository at this point in the history

  20. Incorporate 'artifact_resolve' into the normal 'process_response' met… 

    …hod.
    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    f4fd4b9 View commit details
    Browse the repository at this point in the history

  21. Add tests for Artifact Resolve/Artifact Binding using the OneLogin_Sa… 

    …ml2_Auth class
    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    11a8beb View commit details
    Browse the repository at this point in the history

  22. Typo in ArtifactResponse.

    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    931ba1f View commit details
    Browse the repository at this point in the history

  23. Add a rudimentary test for the error case when using OneLogin_Saml2_Auth 

    to do ArtifactResolve/Artifact Binding.
    Alexander Schrijver committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    cf68798 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Add test for ArtifactResponse parsing using the new Artifact_Response… 

    … class.
    Alexander Schrijver committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    27d1c28 View commit details
    Browse the repository at this point in the history

  2. Add responses to the dependencies and add a missing comma.

    Alexander Schrijver committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    87e91c2 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Add the ability to change the ProtocolBinding in the authn request.

    Alexander Schrijver committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    d7c9126 View commit details
    Browse the repository at this point in the history