Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for small Copy and Paste Error in ABAP CDS Sample #13

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

DerGuteWolf
Copy link
Contributor

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Nov 9, 2022

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Nov 9, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Nov 9, 2022

Hello , thanks for your contribution! We really appreciate it and will look into this .

@JannaLisa
Copy link
Contributor

Hi @DerGuteWolf ,
This does indeed appear to be a mistake in our sample code.
Well spotted!
We will fix this and the corrected version will be visible with 1.109.
Thanks.

@didzvein
Copy link

Hello @DerGuteWolf,
thanks for your contribution. The sample code in documentation has been fixed, and it will be visible in 1.109.

@KvM2 KvM2 self-assigned this Jan 25, 2023
@JannaLisa JannaLisa merged commit 858c375 into SAP-docs:main Jan 25, 2023
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Jan 25, 2023
@sap-doc-bot
Copy link

sap-doc-bot bot commented Jan 25, 2023

Thank you for your valuable content contribution, @DerGuteWolf! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@DerGuteWolf
Copy link
Contributor Author

@qmacro qmacro added the mission-award SAP Community mission award label Sep 27, 2023
@OlMue OlMue added the type/examples-samples Related to existing examples/samples, or request for new examples/samples. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution mission-award SAP Community mission award SAP Fiori elements type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants