Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(FE): Fix CAP CDS annotation for LineItem #137

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

bugwelle
Copy link
Contributor

@bugwelle bugwelle commented Jul 1, 2024

A single quote was missing in the snippet.

A single quote was missing in the snippet.
Copy link

cla-assistant bot commented Jul 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jul 1, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OlMue
Copy link
Contributor

OlMue commented Jul 1, 2024

Hi @bugwelle, thanks a lot for pointing this out. We're on it.

@mishuagrawal
Copy link
Contributor

mishuagrawal commented Jul 1, 2024

Hello @bugwelle,

Thank you for reaching out to us. I have now corrected the document and the change should start reflecting with our upcoming release. Please let us know if there is anything else we can help you with.

Thanks and regards,
Mishu Agrawal

@bugwelle
Copy link
Contributor Author

bugwelle commented Jul 1, 2024

Thanks, @mishuagrawal . I take it that the change is handled outside of this PR and I can close it? :)

@mishuagrawal
Copy link
Contributor

Hello @bugwelle, yes you are right. I have already fixed the document but the change reflection will take some time. If its alright with you, I can go ahead and merge this PR.

Please let me know. Thank you!

@bugwelle
Copy link
Contributor Author

bugwelle commented Jul 1, 2024

@mishuagrawal Thanks! Whatever suites you best. If you can merge it, that'd be great. :)

@mishuagrawal
Copy link
Contributor

Hello @bugwelle,

Thank you for your confirmation. I will go ahead and merge the PR.

@mishuagrawal mishuagrawal merged commit 17b724e into SAP-docs:main Jul 2, 2024
3 checks passed
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Jul 2, 2024
Copy link

sap-doc-bot bot commented Jul 2, 2024

Thank you for your valuable content contribution, @bugwelle! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

@bugwelle bugwelle deleted the patch-1 branch July 2, 2024 08:36
@mishuagrawal mishuagrawal added SAP Fiori elements type/other Other documentation problem. labels Jul 2, 2024
@bugwelle
Copy link
Contributor Author

bugwelle commented Jul 2, 2024

264793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution SAP Fiori elements type/other Other documentation problem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants