Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptor-manifest-json-74038a5.md #147

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

wridgeu
Copy link
Contributor

@wridgeu wridgeu commented Aug 4, 2024

Hi,

minor change to make the example manifest.json a valid JSON.

I came back to this page a few times to quickly grab the example and test a few things. Might as well make it a proper/valid JSON example to use copy/paste on.

BR.

Minor change to make the example `manifest.json` a valid JSON. 

I came back to this page a few times to quickly grab the example and test a few things. Might as well make it a proper/valid JSON example to use copy/paste on.
Copy link

cla-assistant bot commented Aug 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Aug 4, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Aug 6, 2024

Hi @wridgeu, thanks for your contribution! We'll look into it and get back to you.

@KvM2 KvM2 self-assigned this Aug 7, 2024
@KvM2 KvM2 added the follow-up-with/dev Clarification with development needed. label Aug 7, 2024
@KvM2
Copy link
Contributor

KvM2 commented Aug 30, 2024

I have updated the documentation for 1.129.

@KvM2 KvM2 merged commit fc96a70 into SAP-docs:main Aug 30, 2024
3 checks passed
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Aug 30, 2024
Copy link

sap-doc-bot bot commented Aug 30, 2024

Thank you for your valuable content contribution, @wridgeu! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

@wridgeu wridgeu deleted the patch-1 branch August 30, 2024 21:11
@wridgeu
Copy link
Contributor Author

wridgeu commented Aug 30, 2024

Thank you for your valuable content contribution, @wridgeu! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

11821

@KvM2 KvM2 added the type/examples-samples Related to existing examples/samples, or request for new examples/samples. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution follow-up-with/dev Clarification with development needed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants