version 1.14.0

com.sap.adt.abapcleaner.app/abapcleaner.product

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <?pde version="3.5"?>
 
-<product name="ABAP cleaner" uid="com.sap.adt.abapcleaner.app" application="com.sap.adt.abapcleaner.standalone.app" version="1.13.4.qualifier" useFeatures="true" includeLaunchers="true">
+<product name="ABAP cleaner" uid="com.sap.adt.abapcleaner.app" application="com.sap.adt.abapcleaner.standalone.app" version="1.14.0" useFeatures="true" includeLaunchers="true">
 
    <configIni use="default">
    </configIni>

com.sap.adt.abapcleaner.app/pom.xml

@@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.sap.adt.abapcleaner</groupId>
   <artifactId>com.sap.adt.abapcleaner.app</artifactId>
-  <version>1.13.4-SNAPSHOT</version>
+  <version>1.14.0</version>
   <name>com.sap.adt.abapcleaner.app</name>
   <packaging>eclipse-repository</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.13.4-SNAPSHOT</version>
+    <version>1.14.0</version>
     <relativePath>../</relativePath>
   </parent>
 

com.sap.adt.abapcleaner.feature/feature.xml

@@ -2,7 +2,7 @@
 <feature
       id="com.sap.adt.abapcleaner.feature"
       label="ABAP cleaner"
-      version="1.13.4.qualifier">
+      version="1.14.0">
 
    <description>
       ABAP cleaner plug-in for ABAP Development Tools

com.sap.adt.abapcleaner.feature/pom.xml

@@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
   <modelVersion>4.0.0</modelVersion>
   <artifactId>com.sap.adt.abapcleaner.feature</artifactId>
   <groupId>com.sap.adt.abapcleaner</groupId>
-  <version>1.13.4-SNAPSHOT</version>
+  <version>1.14.0</version>
   <name>com.sap.adt.abapcleaner.feature</name>
   <packaging>eclipse-feature</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.13.4-SNAPSHOT</version>
+    <version>1.14.0</version>
     <relativePath>../</relativePath>
   </parent>
 

com.sap.adt.abapcleaner.gui/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: com.sap.adt.abapcleaner.gui;singleton:=true
-Bundle-Version: 1.13.4.qualifier
+Bundle-Version: 1.14.0
 Bundle-Vendor: %Provider-Name
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-11

com.sap.adt.abapcleaner.gui/pom.xml

@@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.sap.adt.abapcleaner</groupId>
   <artifactId>com.sap.adt.abapcleaner.gui</artifactId>
-  <version>1.13.4-SNAPSHOT</version>
+  <version>1.14.0</version>
   <name>com.sap.adt.abapcleaner.gui</name>
   <packaging>eclipse-plugin</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.13.4-SNAPSHOT</version>
+    <version>1.14.0</version>
     <relativePath>../</relativePath>
   </parent>
 

com.sap.adt.abapcleaner.updatesite/pom.xml

@@ -2,14 +2,14 @@
 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0">
   <modelVersion>4.0.0</modelVersion>
   <artifactId>com.sap.adt.abapcleaner.updatesite</artifactId>
-  <version>1.13.4-SNAPSHOT</version>
+  <version>1.14.0</version>
   <name>ABAP Cleaner for ABAP Development Tools (ADT)</name>
   <packaging>eclipse-repository</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.13.4-SNAPSHOT</version>
+    <version>1.14.0</version>
     <relativePath>../</relativePath>
   </parent>
 

com.sap.adt.abapcleaner/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: com.sap.adt.abapcleaner;singleton:=true
-Bundle-Version: 1.13.4.qualifier
+Bundle-Version: 1.14.0
 Bundle-Vendor: %Provider-Name
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-11

com.sap.adt.abapcleaner/pom.xml

@@ -3,14 +3,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.sap.adt.abapcleaner</groupId>
   <artifactId>com.sap.adt.abapcleaner</artifactId>
-  <version>1.13.4-SNAPSHOT</version>
+  <version>1.14.0</version>
   <name>com.sap.adt.abapcleaner</name>
   <packaging>eclipse-plugin</packaging>
 
   <parent>
     <artifactId>parent</artifactId>
     <groupId>com.sap.adt.abapcleaner</groupId>
-    <version>1.13.4-SNAPSHOT</version>
+    <version>1.14.0</version>
     <relativePath>../</relativePath>
   </parent>
 

com.sap.adt.abapcleaner/src/com/sap/adt/abapcleaner/programbase/Program.java

@@ -55,6 +55,7 @@ public static String getVersion() {
 
 	public static Release[] getReleases() {
 		return new Release[] { 
+				Release.create("1.14.0", 2024, 3, 11), 
 				Release.create("1.13.0", 2024, 1, 5), 
 				Release.create("1.12.0", 2023, 11, 27), 
 				Release.create("1.11.0", 2023, 11, 6), 

com.sap.adt.abapcleaner/src/com/sap/adt/abapcleaner/rules/commands/ReadTableRule.java

@@ -97,7 +97,10 @@ public String getExample() {
 			+ LINE_SEP + "    READ TABLE its_any FROM is_any TRANSPORTING NO FIELDS." 
 			+ LINE_SEP + "    CHECK sy-subrc = 0." 
 			+ LINE_SEP 
-			+ LINE_SEP + "    \" replacing [REFERENCE] INTO would require exception handling for CX_SY_TAB_LINE_NOT_FOUND"
+			+ LINE_SEP + "    \" replacing INTO or REFERENCE INTO would require catching the exception CX_SY_TAB_LINE_NOT_FOUND: While"
+			+ LINE_SEP + "    \" VALUE #( itab[ ... ] OPTIONAL ) and REF #( itab[ ... ] OPTIONAL ) work without exception handling, their" 
+			+ LINE_SEP + "    \" behavior differs from READ TABLE if the table line is NOT found: In this case, READ TABLE preserves the old"
+			+ LINE_SEP + "    \" value of the variable, while the VALUE #( ) and REF #( ) constructors would initialize the variable"
 			+ LINE_SEP + "    READ TABLE its_any WITH KEY comp1 = 'abc' INTO DATA(ls_any)." 
 			+ LINE_SEP + "    READ TABLE its_any WITH KEY comp1 = 'def' REFERENCE INTO lr_any." 
 			+ LINE_SEP 

docs/release-notes.md

@@ -6,6 +6,15 @@ as well as bugfixes of reported issues, i.e. anything that enhances or changes t
 For a complete list of changes (including documentation, tests, refactoring etc.), please refer to 
 the list of [commits](../../../commits/main).
 
+## 2024-03-11 (version 1.14.0)
+
+Many **thanks** to [**jelliottp**](https://github.com/jelliottp) for inspiring these improvements!
+
+* Added new rule '**Replace READ TABLE with table expression**' ([#36](../../../issues/36))
+* Added new rule '**Replace DESCRIBE TABLE ... LINES with lines( )**' ([#36](../../../issues/36))
+* Added further **references to Code Pal** for ABAP
+* Updated **link** to webinar on **Open Source journey** of ABAP cleaner
+
 ## 2024-02-28 (version 1.13.3)
 
 * Fixed rule '**Shorten VALUE statements**' for **comment line at end** of parenthesis

docs/rules.md

@@ -1,6 +1,6 @@
 # Available Cleanup Rules
 
-ABAP cleaner offers 70 cleanup rules with a total of 275 configuration options:
+ABAP cleaner offers 72 cleanup rules with a total of 279 configuration options:
 
 ## Empty Lines
 
@@ -63,6 +63,8 @@ ABAP cleaner offers 70 cleanup rules with a total of 275 configuration options:
 * [Replace obsolete ADD ... TO etc. with \+= etc.](rules/AddToEtcRule.md)
 * [Replace obsolete MOVE ... TO with =](rules/MoveToRule.md)
 * [Replace TRANSLATE with string functions](rules/TranslateRule.md)
+* [Replace DESCRIBE TABLE ... LINES with lines\( \)](rules/DescribeTableRule.md)
+* [Replace READ TABLE with table expression](rules/ReadTableRule.md)
 * [Use assert\_true and assert\_false](rules/AssertEqualsBooleanRule.md)
 * [Use assert\_subrc instead of assert\_equals](rules/AssertEqualsSubrcRule.md)
 * [Use assert class instead of ASSERT](rules/AssertClassRule.md)

docs/rules/AssertEqualsBooleanRule.md

@@ -1,4 +1,4 @@
-[<-- previous rule](TranslateRule.md) | [overview](../rules.md) | [next rule -->](AssertEqualsSubrcRule.md)
+[<-- previous rule](ReadTableRule.md) | [overview](../rules.md) | [next rule -->](AssertEqualsSubrcRule.md)
 
 # Use assert\_true and assert\_false
 

docs/rules/CallMethodRule.md

@@ -12,7 +12,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 
 * [Clean ABAP Styleguide: Prefer functional to procedural calls](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls)
 * [Clean ABAP Styleguide: Avoid obsolete language elements](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-obsolete-language-elements)
-* [Clean Code Checks: CALL METHOD Usage](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/call-method-usage.md)
+* [Code Pal for ABAP: CALL METHOD Usage](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/call-method-usage.md)
 * [ABAP Keyword Documentation: Formulate static method calls without CALL METHOD](https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abenmethod_call_guidl.htm)
 * [ABAP Keyword Documentation: Obsolete Calls: CALL METHOD, Static](https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abapcall_method_static.htm)
 

docs/rules/ChainRule.md

@@ -9,7 +9,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 ## References
 
 * [Clean ABAP Styleguide: Do not chain up-front declarations](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#do-not-chain-up-front-declarations)
-* [Clean Code Checks: Chain Declaration Usage](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/chain-declaration-usage.md)
+* [Code Pal for ABAP: Chain Declaration Usage](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/chain-declaration-usage.md)
 * [ABAP Keyword Documentation: Only use chained statements where appropriate](https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abenchained_statements_guidl.htm)
 
 ## Options

docs/rules/CheckInLoopRule.md

@@ -9,7 +9,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 ## References
 
 * [Clean ABAP Styleguide: Avoid CHECK in other positions](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-check-in-other-positions)
-* [Clean Code Checks: CHECK in LOOP](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/check-in-loop.md)
+* [Code Pal for ABAP: CHECK in LOOP](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/check-in-loop.md)
 
 ## Options
 

docs/rules/CheckOutsideLoopRule.md

@@ -10,7 +10,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 
 * [Clean ABAP Styleguide: CHECK vs. RETURN](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return)
 * [Clean ABAP Styleguide: Avoid CHECK in other positions](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-check-in-other-positions)
-* [Clean Code Checks: CHECK Statement Position](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/check-statement-position.md)
+* [Code Pal for ABAP: CHECK Statement Position](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/check-statement-position.md)
 
 ## Options
 

docs/rules/CommentTypeRule.md

@@ -9,7 +9,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 ## References
 
 * [Clean ABAP Styleguide: Comment with ", not with \*](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#comment-with--not-with-)
-* [Clean Code Checks: Comment Type](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/comment-type.md)
+* [Code Pal for ABAP: Comment Type](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/comment-type.md)
 
 ## Options
 

docs/rules/CreateObjectRule.md

@@ -11,6 +11,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 ## References
 
 * [Clean ABAP Styleguide: Prefer NEW to CREATE OBJECT](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-new-to-create-object)
+* [Code Pal for ABAP: Prefer New to Create Object](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/prefer-new-to-create-object.md)
 
 ## Options
 

docs/rules/DescribeTableRule.md

@@ -0,0 +1,86 @@
+[<-- previous rule](TranslateRule.md) | [overview](../rules.md) | [next rule -->](ReadTableRule.md)
+
+# Replace DESCRIBE TABLE ... LINES with lines\( \)
+
+Replaces DESCRIBE TABLE ... LINES with the built-in function lines\( \).
+
+Statements cannot be replaced if they use other additions \(KIND ... or OCCURS ...\) or SY-TFILL / SY-TLENG are evaluated afterwards.
+
+This rule is part of the **essential** profile, as it is explicitly demanded by the [Clean ABAP Styleguide](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md).
+
+## References
+
+* [Clean ABAP Styleguide: Prefer functional to procedural language constructs](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-language-constructs)
+
+## Options
+
+* \(no options available for this rule\)
+
+## Examples
+
+
+```ABAP
+
+  METHOD describe_table_lines.
+    " the following cases can be replaced with the built-in function lines( ):
+    DESCRIBE TABLE its_any_table LINES ev_any_line_count.
+    DESCRIBE TABLE its_any_table LINES DATA(lv_any_line_count).
+    DESCRIBE TABLE its_other_table LINES FINAL(lv_other_line_count).
+
+    " DESCRIBE TABLE with other additions cannot be replaced
+    DESCRIBE TABLE it_third_table KIND DATA(lv_kind) LINES lv_any_line_count.
+    DESCRIBE TABLE it_third_table OCCURS FINAL(lv_init_mem_requirement).
+
+    " DESCRIBE TABLE with any subsequent evaluation of SY-TLENG or SY-TFILL cannot be replaced
+    DESCRIBE TABLE it_third_table LINES lv_any_line_count.
+    DATA(lv_line_count) = sy-tfill.
+    DATA(lv_line_length_in_bytes) = sy-tleng.
+
+    " here, SY-TLENG is also evaluated in the program flow after DESCRIBE TABLE
+    " (but only for the second one, so the first one can be changed)
+    DO 3 TIMES.
+      IF sy-index = 3.
+        RETURN sy-tleng.
+      ENDIF.
+      DESCRIBE TABLE it_third_table LINES lv_any_line_count.
+      DESCRIBE TABLE it_fourth_table LINES lv_line_count.
+    ENDDO.
+  ENDMETHOD.
+```
+
+Resulting code:
+
+```ABAP
+
+  METHOD describe_table_lines.
+    " the following cases can be replaced with the built-in function lines( ):
+    ev_any_line_count = lines( its_any_table ).
+    DATA(lv_any_line_count) = lines( its_any_table ).
+    FINAL(lv_other_line_count) = lines( its_other_table ).
+
+    " DESCRIBE TABLE with other additions cannot be replaced
+    DESCRIBE TABLE it_third_table KIND DATA(lv_kind) LINES lv_any_line_count.
+    DESCRIBE TABLE it_third_table OCCURS FINAL(lv_init_mem_requirement).
+
+    " DESCRIBE TABLE with any subsequent evaluation of SY-TLENG or SY-TFILL cannot be replaced
+    DESCRIBE TABLE it_third_table LINES lv_any_line_count.
+    DATA(lv_line_count) = sy-tfill.
+    DATA(lv_line_length_in_bytes) = sy-tleng.
+
+    " here, SY-TLENG is also evaluated in the program flow after DESCRIBE TABLE
+    " (but only for the second one, so the first one can be changed)
+    DO 3 TIMES.
+      IF sy-index = 3.
+        RETURN sy-tleng.
+      ENDIF.
+      lv_any_line_count = lines( it_third_table ).
+      DESCRIBE TABLE it_fourth_table LINES lv_line_count.
+    ENDDO.
+  ENDMETHOD.
+```
+
+## Related code
+
+* [Rule implementation](../../com.sap.adt.abapcleaner/src/com/sap/adt/abapcleaner/rules/commands/DescribeTableRule.java)
+* [Tests](../../test/com.sap.adt.abapcleaner.test/src/com/sap/adt/abapcleaner/rules/commands/DescribeTableTest.java)
+

docs/rules/EqualsSignChainRule.md

@@ -11,7 +11,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 ## References
 
 * [Clean ABAP Styleguide: Don't chain assignments](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-chain-assignments)
-* [Clean Code Checks: Equals Sign Chaining](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/equals-sign-chaining.md)
+* [Code Pal for ABAP: Equals Sign Chaining](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/equals-sign-chaining.md)
 
 ## Options
 

docs/rules/ExportingKeywordRule.md

@@ -9,7 +9,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 ## References
 
 * [Clean ABAP Styleguide: Omit the optional keyword EXPORTING](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting)
-* [Clean Code Checks: Omit Optional EXPORTING](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/omit-optional-exporting.md)
+* [Code Pal for ABAP: Omit Optional EXPORTING](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/omit-optional-exporting.md)
 
 ## Options
 

docs/rules/IndentRule.md

@@ -12,7 +12,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 
 * [Clean ABAP Styleguide: Use the Pretty Printer before activating](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-the-pretty-printer-before-activating)
 * [Clean ABAP Styleguide: Use your Pretty Printer team settings](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-your-pretty-printer-team-settings)
-* [Clean Code Checks: Comment Position](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/comment-position.md)
+* [Code Pal for ABAP: Comment Position](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/comment-position.md)
 
 ## Options
 

docs/rules/LocalDeclarationOrderRule.md

@@ -8,7 +8,7 @@ Moving declarations to their innermost block is discouraged, but may help to ref
 
 ## References
 
-* [Clean Code Checks: Scope of Variable](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/scope-of-variable.md)
+* [Code Pal for ABAP: Scope of Variable](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/scope-of-variable.md)
 
 ## Options
 

docs/rules/NotIsRule.md

@@ -9,7 +9,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 ## References
 
 * [Clean ABAP Styleguide: Prefer IS NOT to NOT IS](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-is-not-to-not-is)
-* [Clean Code Checks: Prefer IS NOT to NOT IS](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/prefer-is-not-to-not-is.md)
+* [Code Pal for ABAP: Prefer IS NOT to NOT IS](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/prefer-is-not-to-not-is.md)
 
 ## Options
 

docs/rules/PseudoCommentRule.md

@@ -11,6 +11,7 @@ This rule is part of the **essential** profile, as it is explicitly demanded by
 ## References
 
 * [Clean ABAP Styleguide: Prefer pragmas to pseudo comments](https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-pragmas-to-pseudo-comments)
+* [Code Pal for ABAP: Prefer Pragmas to Pseudo Comments](https://github.com/SAP/code-pal-for-abap/blob/master/docs/checks/prefer-pragmas-to-pseudo-comments.md)
 * [ABAP Keyword Documentation: Pseudo Comments for the Extended Program Check](https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abenpseudo_comment_slin.htm)
 * [ABAP Keyword Documentation: Pragmas](https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abenpragma.htm)