feat: Allow NoAuthentication for OnPremise MAIL destination #5137
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongpinWang
reviewed
Nov 6, 2024
| destination.proxyType === 'OnPremise' && | ||
| destination.authentication === 'NoAuthentication' | ||
| ) { | ||
| return { username: '', password: '' }; |
There was a problem hiding this comment.
Not sure if this is the best way setting empty username and password. According to https://nodemailer.com/smtp/#authentication, if authentication is not needed, maybe we should leave auth out in createTransport. Could you please test this?
| @@ -76,6 +76,12 @@ function getCredentials( | |||
| destination: Destination, | |||
| originalProperties: Record<string, any> | |||
| ): { username: string; password: string } { | |||
| if ( | |||
| destination.proxyType === 'OnPremise' && | |||
There was a problem hiding this comment.
Here, since internet smtp server can also have no username/password, I would leave this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #5136