chore: fix lint error in cx, i18n and nx-plugin

SAP · Dec 23, 2024 · acf53f5 · acf53f5
1 parent 776f39b
commit acf53f5
Show file tree

Hide file tree

Showing 11 changed files with 109 additions and 234 deletions.
diff --git a/libs/cx/.eslintrc.json b/libs/cx/.eslintrc.json
diff --git a/libs/cx/eslint.config.js b/libs/cx/eslint.config.js
@@ -1,34 +1,38 @@
 const nx = require('@nx/eslint-plugin');
 const baseConfig = require('../../eslint.config.js');
+const overrides = require('../../eslint.overrides');
 
 module.exports = [
-  ...baseConfig,
-  ...nx.configs['flat/angular'],
-  ...nx.configs['flat/angular-template'],
-  {
-    files: ['**/*.ts'],
-    rules: {
-      '@angular-eslint/directive-selector': [
-        'error',
-        {
-          type: 'attribute',
-          prefix: 'app',
-          style: 'camelCase',
-        },
-      ],
-      '@angular-eslint/component-selector': [
-        'error',
-        {
-          type: 'element',
-          prefix: 'app',
-          style: 'kebab-case',
-        },
-      ],
+    ...baseConfig,
+    ...nx.configs['flat/angular'],
+    ...nx.configs['flat/angular-template'],
+    ...overrides,
+    {
+        files: ['**/*.ts'],
+        rules: {
+            '@angular-eslint/directive-selector': [
+                'error',
+                {
+                    type: 'attribute',
+                    prefix: 'fdx',
+                    style: 'camelCase'
+                }
+            ],
+            '@angular-eslint/component-selector': [
+                'error',
+                {
+                    type: 'element',
+                    prefix: 'fdx',
+                    style: 'kebab-case'
+                }
+            ]
+        }
     },
-  },
-  {
-    files: ['**/*.html'],
-    // Override or add rules here
-    rules: {},
-  },
+    {
+        files: ['**/*.html'],
+        // Override or add rules here
+        rules: {
+            '@angular-eslint/template/elements-content': 'off'
+        }
+    }
 ];
diff --git a/libs/datetime-adapter/.eslintrc.json b/libs/datetime-adapter/.eslintrc.json
diff --git a/libs/i18n/.eslintrc.json b/libs/i18n/.eslintrc.json
diff --git a/libs/i18n/eslint.config.js b/libs/i18n/eslint.config.js
@@ -2,33 +2,33 @@ const nx = require('@nx/eslint-plugin');
 const baseConfig = require('../../eslint.config.js');
 
 module.exports = [
-  ...baseConfig,
-  ...nx.configs['flat/angular'],
-  ...nx.configs['flat/angular-template'],
-  {
-    files: ['**/*.ts'],
-    rules: {
-      '@angular-eslint/directive-selector': [
-        'error',
-        {
-          type: 'attribute',
-          prefix: 'app',
-          style: 'camelCase',
-        },
-      ],
-      '@angular-eslint/component-selector': [
-        'error',
-        {
-          type: 'element',
-          prefix: 'app',
-          style: 'kebab-case',
-        },
-      ],
+    ...baseConfig,
+    ...nx.configs['flat/angular'],
+    ...nx.configs['flat/angular-template'],
+    {
+        files: ['**/*.ts'],
+        rules: {
+            '@angular-eslint/directive-selector': [
+                'error',
+                {
+                    type: 'attribute',
+                    prefix: 'fd',
+                    style: 'camelCase'
+                }
+            ],
+            '@angular-eslint/component-selector': [
+                'error',
+                {
+                    type: 'element',
+                    prefix: 'fd',
+                    style: 'kebab-case'
+                }
+            ]
+        }
     },
-  },
-  {
-    files: ['**/*.html'],
-    // Override or add rules here
-    rules: {},
-  },
+    {
+        files: ['**/*.html'],
+        // Override or add rules here
+        rules: {}
+    }
 ];
diff --git a/libs/moment-adapter/.eslintrc.json b/libs/moment-adapter/.eslintrc.json
diff --git a/libs/nx-plugin/eslint.config.js b/libs/nx-plugin/eslint.config.js
@@ -2,33 +2,39 @@ const nx = require('@nx/eslint-plugin');
 const baseConfig = require('../../eslint.config.js');
 
 module.exports = [
-  ...baseConfig,
-  ...nx.configs['flat/angular'],
-  ...nx.configs['flat/angular-template'],
-  {
-    files: ['**/*.ts'],
-    rules: {
-      '@angular-eslint/directive-selector': [
-        'error',
-        {
-          type: 'attribute',
-          prefix: 'app',
-          style: 'camelCase',
-        },
-      ],
-      '@angular-eslint/component-selector': [
-        'error',
-        {
-          type: 'element',
-          prefix: 'app',
-          style: 'kebab-case',
-        },
-      ],
+    ...baseConfig,
+    ...nx.configs['flat/angular'],
+    ...nx.configs['flat/angular-template'],
+    {
+        files: ['**/*.ts', '**/*.tsx'],
+        rules: {
+            '@angular-eslint/directive-selector': [
+                'error',
+                {
+                    type: 'attribute',
+                    prefix: 'app',
+                    style: 'camelCase'
+                }
+            ],
+            '@angular-eslint/component-selector': [
+                'error',
+                {
+                    type: 'element',
+                    prefix: 'app',
+                    style: 'kebab-case'
+                }
+            ],
+            '@typescript-eslint/explicit-function-return-type': 'off',
+            '@typescript-eslint/no-var-requires': 'off',
+            'grouped-accessor-pairs': 'off',
+            '@typescript-eslint/no-shadow': 'off',
+            'no-unused-vars': 'off',
+            'no-bitwise': 'off'
+        }
     },
-  },
-  {
-    files: ['**/*.html'],
-    // Override or add rules here
-    rules: {},
-  },
+    {
+        files: ['**/*.html'],
+        // Override or add rules here
+        rules: {}
+    }
 ];
diff --git a/libs/nx-plugin/src/executors/compile-typedoc/theme/partials/comment.summary.tsx b/libs/nx-plugin/src/executors/compile-typedoc/theme/partials/comment.summary.tsx
@@ -2,7 +2,9 @@ import { DefaultThemeRenderContext, JSX, Reflection } from 'typedoc';
 import { fixedMarkdown } from '../utils';
 
 export function commentSummary(context: DefaultThemeRenderContext, props: Reflection) {
-    if (!props.comment?.summary.some((part) => part.text)) return;
+    if (!props.comment?.summary.some((part) => part.text)) {
+        return;
+    }
 
     return (
         <>

diff --git a/libs/nx-plugin/src/executors/compile-typedoc/theme/partials/comment.tags.tsx b/libs/nx-plugin/src/executors/compile-typedoc/theme/partials/comment.tags.tsx
@@ -2,7 +2,9 @@ import { DefaultThemeRenderContext, JSX, Reflection, ReflectionKind } from 'type
 import { camelToTitleCase, fixedMarkdown } from '../utils';
 
 export function commentTags({ markdown }: DefaultThemeRenderContext, props: Reflection) {
-    if (!props.comment) return;
+    if (!props.comment) {
+        return;
+    }
 
     const tags = props.kindOf(ReflectionKind.SomeSignature)
         ? props.comment.blockTags.filter((tag) => tag.tag !== '@returns')

diff --git a/libs/nx-plugin/src/executors/compile-typedoc/theme/partials/hierarchy.tsx b/libs/nx-plugin/src/executors/compile-typedoc/theme/partials/hierarchy.tsx
@@ -2,7 +2,9 @@ import { DeclarationHierarchy, DefaultThemeRenderContext, JSX } from 'typedoc';
 import { hierarchyList } from '../utils';
 
 export function hierarchy(context: DefaultThemeRenderContext, props: DeclarationHierarchy | undefined) {
-    if (!props) return;
+    if (!props) {
+        return;
+    }
 
     return (
         <section class="tsd-panel tsd-hierarchy">