Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): form generator - fix form generator button group alignment #12700

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

khotcholava
Copy link
Contributor

fix(platform): fix form generator button group alignment

closes #11003

Description

  • Fixed radio button alignment
  • Updated fundamental styles version to the latest

Snapshots

Before

Screenshot 2024-11-07 at 18 47 46

After

Screenshot 2024-11-07 at 18 47 55

khotcholavaSuzy and others added 3 commits November 4, 2024 14:21
closes [#11003](#11003)

- fixing segment button value conflict issue
closes [#11003](#11003)

- Fixed radio group alignment for form generator
@khotcholava khotcholava self-assigned this Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys

Name Link
🔨 Latest commit e9630e2
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/676561b998b5760008804905

Copy link

github-actions bot commented Nov 7, 2024

Visit the preview URL for this PR (updated for commit e9630e2):

https://fundamental-ngx-gh--pr12700-11003-form-generator-ecteas6z.web.app

(expires Mon, 23 Dec 2024 12:27:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebase main so that the latest theming-base-content (11.22.0) kicks in and you won't have missing borders for the radio buttons
Screenshot 2024-11-12 at 11 30 43 AM

Also, I am blocking the PR as it's using the RC version of fund-styles. We need a non-RC version so that it goes to main.

@droshev droshev added this to the Sprint 140 - November 2024 milestone Nov 13, 2024
@droshev
Copy link
Contributor

droshev commented Nov 20, 2024

@khotcholava to investigate why e2e are failing.

@droshev
Copy link
Contributor

droshev commented Nov 26, 2024

@khotcholava to investigate why e2e are still failing.

@khotcholava khotcholava marked this pull request as draft November 27, 2024 14:46
@khotcholava
Copy link
Contributor Author

@droshev The failing e2e test in this PR is unrelated to the changes here. I tested it on the main branch, and it fails there as well.

I'll continue investigating the cause of the failing e2e test, but it shouldn't prevent us from merging this PR.

The only blocker for this PR, as Inna mentioned in her comment, is the use of a non-RC version.

@khotcholava khotcholava force-pushed the 11003-form-generator-radio-alignment-fix branch from f58769b to 4b7b6b9 Compare December 11, 2024 12:47
@droshev
Copy link
Contributor

droshev commented Dec 18, 2024

@khotcholava remove the RC styles dependencies, copy over the CSS in the component.scss file as a temp solution, resolve the conflicts, make sure e2e/unit are passing, convert it to PR. Then we would need to review it quickly.

# Conflicts:
#	libs/docs/platform/input/e2e/input.e2e-spec.ts
@droshev droshev self-assigned this Dec 20, 2024
@droshev
Copy link
Contributor

droshev commented Dec 20, 2024

@droshev to take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(form-generator: radio) radio buttons misaligned on small screens
6 participants