-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform): form generator - fix form generator button group alignment #12700
base: main
Are you sure you want to change the base?
Conversation
❌ Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys
|
Visit the preview URL for this PR (updated for commit e9630e2): https://fundamental-ngx-gh--pr12700-11003-form-generator-ecteas6z.web.app (expires Mon, 23 Dec 2024 12:27:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Conflicts: # yarn.lock
@khotcholava to investigate why e2e are failing. |
@khotcholava to investigate why e2e are still failing. |
@droshev The failing e2e test in this PR is unrelated to the changes here. I tested it on the main branch, and it fails there as well. I'll continue investigating the cause of the failing e2e test, but it shouldn't prevent us from merging this PR. The only blocker for this PR, as Inna mentioned in her comment, is the use of a non-RC version. |
f58769b
to
4b7b6b9
Compare
@khotcholava remove the RC styles dependencies, copy over the CSS in the component.scss file as a temp solution, resolve the conflicts, make sure e2e/unit are passing, convert it to PR. Then we would need to review it quickly. |
# Conflicts: # libs/docs/platform/input/e2e/input.e2e-spec.ts
@droshev to take over. |
fix(platform): fix form generator button group alignment
closes #11003
Description
Snapshots
Before
After