-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to eslint 9 and the flat configuration #12877
Open
robertIsaac
wants to merge
22
commits into
main
Choose a base branch
from
eslint-9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys
|
as versions before that doesn't support flat config
robertIsaac
force-pushed
the
eslint-9
branch
from
December 23, 2024 15:37
831184e
to
cf8ba74
Compare
robertIsaac
force-pushed
the
eslint-9
branch
from
December 23, 2024 19:37
f1849ae
to
830987e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently the repo is using the old
.eslintrc
and the unsupport eslint 8 versionsthis PR migrate to the new flat configuration and eslint 9
I also updated nx since the old version was buggy, you may want to do the upgrade in a separate branch first which is understandable
note that I didn't add all the old plugins, this can be done in a future PR, or if mandatory I can work on it in the future