Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): broken examples, defect hunting 103 #4122

Merged
merged 4 commits into from
Dec 26, 2022
Merged

fix(docs): broken examples, defect hunting 103 #4122

merged 4 commits into from
Dec 26, 2022
+255 −157

Conversation

platon-rov
Copy link
Contributor

@platon-rov platon-rov commented Dec 19, 2022 •
edited
Loading

Related Issue

Relates to #3955 (comment)
Relates to #3955 (comment)
Relates to #3955 (comment)

Description

Various broken examples fixes.

Screenshots

Before:

Dynamic Page
image

Table
image

Object Status
image

After:

Dynamic Page
CleanShot 2022-12-19 at 13 56 34@2x

Table
CleanShot 2022-12-19 at 15 14 13@2x
CleanShot 2022-12-19 at 15 14 40@2x

Object Status
CleanShot 2022-12-19 at 16 33 25@2x

@platon-rov platon-rov added Bug Something isn't working Defect Hunting labels Dec 19, 2022
@platon-rov platon-rov added this to the Sprint 103 - Zurich milestone Dec 19, 2022
@platon-rov platon-rov requested a review from a team December 19, 2022 12:57
@platon-rov platon-rov self-assigned this Dec 19, 2022
@platon-rov platon-rov mentioned this pull request Dec 19, 2022
Closed
@netlify
Copy link

netlify bot commented Dec 19, 2022 •
edited
Loading

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 1f46fdf
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/63a1ebc020d58f00086f3560
😎 Deploy Preview https://deploy-preview-4122--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@platon-rov platon-rov changed the title fix(docs): dynamic page broken example fix(docs): broken examples, defect hunting 103 Dec 19, 2022
g-cheishvili
g-cheishvili suggested changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@g-cheishvili g-cheishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe quote changes were not intended and PR needs snapshots update

@platon-rov platon-rov merged commit 1a8b829 into main Dec 26, 2022
@platon-rov platon-rov deleted the pr/fix/broken-examples-dh-103 branch December 26, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@g-cheishvili g-cheishvili g-cheishvili approved these changes

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

Assignees

@platon-rov platon-rov

Labels
Bug Something isn't working Defect Hunting
Projects
None yet
Milestone
Sprint 103 - Zurich
Development

Successfully merging this pull request may close these issues.
4 participants
@platon-rov @mikerodonnell89 @g-cheishvili @InnaAtanasova