-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): update Calendar component - Horizon 2023 #4514
Conversation
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The focus outline should be on top of the special day indicator. Maybe use z-index.
- Wrong BEM in my opinion in this case:
fd-calendar__item fd-calendar__item--weekend fd-calendar__item--current is-active fd-calendar__special-day--1
The block is fd-calendar__item
and the following modifier classes modify the default behaviour: fd-calendar__item--weekend
and fd-calendar__item--current
, but the class fd-calendar__special-day--1
is not used properly. Here are the problems:
fd-calendar__special-day--1
is a block and can't be used together with another block (in this casefd-calendar__item
- you need
fd-calendar__special-day
to have thefd-calendar__special-day--1
But in general, I wouldn't use 2 block classes on the same element
- Related to the above comment:
fd-calendar__item fd-calendar__special-day fd-calendar__special-day--2
the workaround could be to use a modifier class for fd-calendar__item
, like fd-calendar__item--special-day-2
c12a479
to
61109b4
Compare
0080afb
to
d5de568
Compare
8b17656
to
dffdb80
Compare
dffdb80
to
a1bf9fe
Compare
a1bf9fe
to
400a25b
Compare
Related Issue
Closes #4369
Description
Update Calendar and Date Picker with the latest Horizon specs
BREAKING CHANGE:
complete calendar markup refactoring(item, navigation, legend). Many classes were removed.
Navigation
Before:
After:
Calendar Day
Before:
After:
Calendar Container
Before:
After: