-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(styles): quick view styles & examples [ci visual] #4685
Conversation
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title should be docs not fix as the changes are for the documentation.
@@ -1,4 +1,4 @@ | |||
<div class="fd-popover"> | |||
<div class="fd-popover" style="margin-bottom: 300px;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a wrapping div element with margin-bottom and not apply it to the Popover as we might confuse the end users. For example:
<div style="margin-bottom: 300px;">
<div class="fd-popover">...</div>
</div>
@@ -1,4 +1,4 @@ | |||
<div class="fd-popover"> | |||
<div class="fd-popover" style="margin-bottom: 500px;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
Related Issue
Relates to #3955 (comment)
Description
Added bottom margin to improve clarity for quick view
Screenshots
Before
After