Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(styles): quick view styles & examples [ci visual] #4685

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

IB002
Copy link
Contributor

@IB002 IB002 commented Jul 12, 2023

Related Issue

Relates to #3955 (comment)

Description

Added bottom margin to improve clarity for quick view

Screenshots

Before

1 2

After

3 4

@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 299d847
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/64b1740112869b0008b3be7f
😎 Deploy Preview https://deploy-preview-4685--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IB002 IB002 changed the title fix(styles): quick view styles & examples fix(styles): quick view styles & examples [ci visual] Jul 12, 2023
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title should be docs not fix as the changes are for the documentation.

@@ -1,4 +1,4 @@
<div class="fd-popover">
<div class="fd-popover" style="margin-bottom: 300px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a wrapping div element with margin-bottom and not apply it to the Popover as we might confuse the end users. For example:

<div style="margin-bottom: 300px;">
    <div class="fd-popover">...</div>
</div>

@@ -1,4 +1,4 @@
<div class="fd-popover">
<div class="fd-popover" style="margin-bottom: 500px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@InnaAtanasova
Copy link
Contributor

Screenshot 2023-07-12 at 1 46 02 PM

This part needs to be maintained.

  • Reviewers should be denoland
  • Assignee is you
  • Label: pick the one that fits best
  • Project: Development
  • Milestone: the current Milestone (this week is 117)

@InnaAtanasova InnaAtanasova requested a review from a team July 12, 2023 17:48
@InnaAtanasova InnaAtanasova added the Doc website documentation website label Jul 12, 2023
@InnaAtanasova InnaAtanasova added this to the Sprint 117 milestone Jul 12, 2023
@InnaAtanasova
Copy link
Contributor

Screenshot 2023-07-12 at 1 48 50 PM

This is how the section should look like

@IB002 IB002 changed the title fix(styles): quick view styles & examples [ci visual] docs(styles): quick view styles & examples [ci visual] Jul 12, 2023
@droshev droshev merged commit 0e1b08e into main Jul 14, 2023
@droshev droshev deleted the fix/quick-view branch July 14, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc website documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants