Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(styles): add the missing checkboxes in Table examples [ci visual] #5600

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Closes none, reported by a user

Description

The checkboxes in Table documentation were missing because the Checkbox component has not been updated with the Breaking changes in the markup. Before it was relying on ::before pseudo element to render the square, now it's a span element.

Before:

<label class="fd-checkbox__label fd-table__checkbox-label" for="Ai4ez611"></label>

After:

<label class="fd-checkbox__label fd-table__checkbox-label" for="Ai4ez611">
    <span class="fd-checkbox__checkmark" aria-hidden="true"></span>
</label>

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/66ce48e6be29749509f956dd
😎 Deploy Preview https://deploy-preview-5600--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@droshev droshev merged commit 6adff4e into main Aug 27, 2024
8 of 10 checks passed
@droshev droshev deleted the docs/missing-checkboxes-in-table branch August 27, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants