Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): refactor Notifications component [ci visual #5616

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Sep 5, 2024

Related Issue

Closes #5598

Description

The Notifications component has been updated to latest design; includes Breaking changes to accommodate the design changes and the a11y requirements. Removed the BTP examples and code, refactored and cleaned-up the code.

BREAKING CHANGES:

  1. the status indicator is now using a normal icon with status color

Before:

<div class="fd-notification__header">
    <div class="fd-notification__indicator fd-notification__indicator--success"></div>
    <h2 class="fd-notification__title fd-notification__title--unread"></h2>
</div>

After:

<div class="fd-notification__header">
    <span class="sap-icon sap-icon--error sap-icon--color-negative"></span>
    <h4 class="fd-notification__title fd-notification__title--unread"></h4>
</div>
  1. Message Strip can be added to a notification group, not to individual items
  2. fd-notification--mobile modifier is removed. The responsiveness is handled automatically with media queries.
  3. fd-notification--in-dialog modifier is removed.
  4. fd-notification--padding modifier is removed.
  5. fd-notification--group modifier is removed. Grouping is handled with different markup.
  6. fd-notification--btp modifier is removed, BTP component is marked as legacy in the design.
  7. fdb-notification__group-header-title is removed, BTP component is marked as legacy in the design.
  8. fd-notification__unread-indicator is removed, BTP component is marked as legacy in the design.
  9. fd-notification__limit is removed, BTP component is marked as legacy in the design.
  10. fd-notification__group-header--collapsed modifier is removed.
  11. New elements for Notification Group

Before:

<div class="fd-notification fd-notification--group">
    <ul class="fd-tabs fd-tabs--l" role="tablist">...</ul>
    <div class="fd-tabs__panel" aria-expanded="true" id="notifV550" role="tabpanel">
        <div class="fd-notification__group-header">....Group Header</div>
        <div class="fd-notification__body">....Notification</div>
        <div class="fd-notification__body">....Notification</div>
        <div class="fd-notification__body">....Notification</div>
        <div class="fd-notification__limit">
            <h1 class="fd-notification__limit--title">...</h1>
            <p class="fd-notification__limit--description">...</p>
        </div>
    </div>
</div>

After:

<div class="fd-notification-popover">
    <div class="fd-toolbar fd-toolbar--title fd-toolbar--clear"></div>
    <div class="fd-notification-message-strip"></div>
    <ul class="fd-notification-list">
        <li class="fd-notification-group">
            <div class="fd-notification-group__wrapper">
                <div class="fd-notification-group__header">
                    <span class="fd-notification-group__header-arrow"></span>
                    <span class="fd-notification-group__header-title">Group Header title...</span>
                 </div>
                 <ul class="fd-notification-group__list">
                     <li class="fd-notification">....Notification</li>
                     <li class="fd-notification">....Notification</li>
                     <li class="fd-notification">....Notification</li>
                </ul>
            </div>
        </li>
        <li class="fd-notification-group">....Notification Group</li>
        <li class="fd-notification-group">....Notification Group</li>
    </ul>
</div>

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit ab36573
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/66def68874a00d0008a163eb
😎 Deploy Preview https://deploy-preview-5616--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@InnaAtanasova InnaAtanasova merged commit 4c34818 into main Sep 9, 2024
10 checks passed
@InnaAtanasova InnaAtanasova deleted the fix/notifications-refactor branch September 9, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification Design Updated
2 participants