Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): inline form group margin block start issue [ci visual] #5674

Closed

Conversation

mikerodonnell89
Copy link
Member

fixes none

Found this on ngx radio button page. Before:
Screenshot 2024-10-02 at 10 18 26 AM

After:
Screenshot 2024-10-02 at 10 20 19 AM

@mikerodonnell89 mikerodonnell89 requested a review from a team October 2, 2024 14:37
@mikerodonnell89 mikerodonnell89 self-assigned this Oct 2, 2024
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 25d7d44
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/6703e6bfd27fbe00085921fa
😎 Deploy Preview https://deploy-preview-5674--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -13,6 +13,11 @@ $block: #{$fd-namespace}-form-group;
justify-content: flex-start;
flex-wrap: wrap;
}

.#{$block}-form-item + .#{$block}-form-item {
-webkit-margin-before: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this line ⬆️

@InnaAtanasova
Copy link
Contributor

InnaAtanasova commented Oct 7, 2024

Actually the fix should be done in form-item.scss file where the spacing is set to 0.625rem.
The top spacing is added in horizontal and vertical form group. It's necessary when we have inputs in a form. This bug needs further investigation and won't be that simple fix. Closing the PR.

Screenshot 2024-10-07 at 10 10 12 AM

Screenshot 2024-10-07 at 10 08 06 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants