fix(styles): remove redundant spacing between form items [ci visual] #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
InnaAtanasova
force-pushed
the
fix/form-item-spacing
branch
from
eb34d24
to
7b106e4
Compare
InnaAtanasova
force-pushed
the
fix/form-item-spacing
branch
from
7b106e4
to
61febc7
Compare
mikerodonnell89
approved these changes
Oct 7, 2024
droshev
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #5660
Description
The extra gap between Radio buttons and the misalignment in inline radio button group was added because form items in a form should have 0.625rem spacing.
Added a new modifier class
fd-form-group--with-spacingthat adds spacing between the form-items only when explicitly applied.Removed the margin-block-start from the form-item.
Without spacing:
With spacing:
