Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gctsdeployupdate #4856

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Gctsdeployupdate #4856

merged 5 commits into from
Mar 27, 2024

Conversation

Anke2016
Copy link
Contributor

@Anke2016 Anke2016 commented Mar 4, 2024

Update gCTSDeploy.yaml

  • Tests
  • [x ] Documentation
    Updated text of scope parameter in gctsDeploy.yaml because it was not precise enough.

@Anke2016 Anke2016 requested a review from a team as a code owner March 4, 2024 16:08
@Anke2016 Anke2016 marked this pull request as draft March 4, 2024 16:09
@Anke2016 Anke2016 marked this pull request as ready for review March 4, 2024 16:12
@sarat-krk sarat-krk self-requested a review March 4, 2024 16:23
@sarat-krk
Copy link
Member

/it-go

@sarat-krk
Copy link
Member

/it

@sarat-krk
Copy link
Member

/it

@sarat-krk
Copy link
Member

/it

@o-liver
Copy link
Member

o-liver commented Mar 27, 2024

/it

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@o-liver
Copy link
Member

o-liver commented Mar 27, 2024

FYI The failing groovy integration tests are not mandatory and this change does not add anything to the groovy side of things. This is only a documentation change and also the go integration test does not check that. So we can merge when ready. Feel free to use the automerge feature to not have the branch get outdated again with the master branch.

@sarat-krk sarat-krk merged commit a1184a7 into SAP:master Mar 27, 2024
12 of 13 checks passed
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* updated text of scope parameter

* go generate all yaml files

---------

Co-authored-by: Sarat Krishnan <[email protected]>
Co-authored-by: Oliver Feldmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants