Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vault): not allowing batch token revoke #4918

Merged
merged 8 commits into from
Oct 22, 2024
Merged

feat(vault): not allowing batch token revoke #4918

merged 8 commits into from
Oct 22, 2024

Conversation

anilkeshav27
Copy link
Member

Changes

this is alternative to #4880 and is a clean way to do it

  • Tests
  • Documentation

@anilkeshav27 anilkeshav27 requested a review from a team as a code owner May 2, 2024 13:02
tiloKo
tiloKo reviewed May 2, 2024
View reviewed changes
Copy link
Member

@tiloKo tiloKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know vault so just some general feedback

pkg/vault/client.go Outdated Show resolved Hide resolved
pkg/vault/client.go Outdated Show resolved Hide resolved
pkg/vault/client.go Outdated Show resolved Hide resolved
pkg/vault/client.go Outdated Show resolved Hide resolved
pkg/vault/client.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vstarostin vstarostin mentioned this pull request May 13, 2024
Closed
2 tasks
@CCFenner CCFenner changed the title feat (vault) not allowing batch token revoke feat(vault): not allowing batch token revoke May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add @SAP/jenkins-library-team to your comment.

@github-actions github-actions bot added the stale marks stale issues and pull requests label Jul 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pull request got stale and no further activity happened. It has automatically been closed. Please re-open in case you still consider it relevant.

@github-actions github-actions bot closed this Jul 30, 2024
@anilkeshav27
Copy link
Member Author

re-working on this pr to allow batch tokens

@anilkeshav27 anilkeshav27 removed the stale marks stale issues and pull requests label Aug 13, 2024
@anilkeshav27 anilkeshav27 reopened this Aug 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

phgermanov
phgermanov reviewed Sep 12, 2024
View reviewed changes
pkg/vault/client.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Googlom
Copy link
Member

Googlom commented Oct 22, 2024

/it-go

@Googlom Googlom self-requested a review October 22, 2024 08:45
@Googlom Googlom merged commit 3ad2628 into master Oct 22, 2024
12 checks passed
@Googlom Googlom deleted the anil/TokenCheckForBatch branch October 22, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiloKo tiloKo tiloKo left review comments

@phgermanov phgermanov phgermanov left review comments

@Googlom Googlom Googlom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anilkeshav27 @Googlom @phgermanov @tiloKo