Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Manifest changes are not reflected after reload #2520

Closed
1 of 3 tasks
voicis opened this issue Nov 1, 2024 · 5 comments
Closed
1 of 3 tasks

BUG - Manifest changes are not reflected after reload #2520

voicis opened this issue Nov 1, 2024 · 5 comments
Assignees
Labels
preview-middleware @sap-ux/preview-middleware

Comments

@voicis
Copy link
Contributor

voicis commented Nov 1, 2024

Description

While using Adaptation Editor if you make a change that modifies manifest, then it will not be reflected in the preview. You can only see it after restarting the editor (from the terminal).

This issue was introduced by #2429

Steps to Reproduce

Steps to reproduce the behavior:

  1. Checkout branch from support semantic date range quick action for v2/v4 #2510
  2. Start Adaptation Editor for a LROP V2 application
  3. Click on Enable/Disable "Semantic Date Range" for Filter Bar
  4. Save and reload

Expected results

The semantic date range configuration is change is reflected in the preview (quick action should also show the opposite name).

Actual results

It still shows the original value.

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

@voicis voicis added the preview-middleware @sap-ux/preview-middleware label Nov 1, 2024
@MN-public
Copy link

@mmilko01 Would it be ok if I assign this issue to you?

@mmilko01 mmilko01 self-assigned this Nov 5, 2024
@mmilko01
Copy link
Contributor

mmilko01 commented Nov 5, 2024

@MN-public I took it. I will discuss with Davis and our team for possible solutions here.

@MN-public
Copy link

@mmilko01 Would it be possible to have the fix merged and consumed for this release? We have 2 days left before the code freeze. Afterwards it would be quite challenging to have it consumed for the release.

@mmilko01
Copy link
Contributor

@MN-public We need do a manual test of the PR from our side and we will merge the PR once done. If everything with the testing passes ok, we should be able to merge before the release.

@mmilko01
Copy link
Contributor

@MN-public @voicis The fix is now merged. There is another issue noticed during the testing, which doesn't seem to be related to this fix. I already discussed with @voicis for further steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview-middleware @sap-ux/preview-middleware
Projects
None yet
Development

No branches or pull requests

3 participants