Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh descriptor after manifest changes #2533

Merged
merged 17 commits into from
Nov 11, 2024

Conversation

mmilko01
Copy link
Contributor

@mmilko01 mmilko01 commented Nov 6, 2024

#2520

Refresh applicationDependencies in editor HTML after manifest changes on reload

Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: c12870d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/adp-tooling Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmilko01 mmilko01 added preview-middleware @sap-ux/preview-middleware adp-tooling bug Something isn't working labels Nov 6, 2024
@mmilko01 mmilko01 marked this pull request as ready for review November 7, 2024 07:31
@mmilko01 mmilko01 requested review from a team as code owners November 7, 2024 07:31
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code changes looks good
  • Review comments addressed
  • Good test coverage
  • Tested locally

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good
Test coverage is good
Did not test manually

Copy link

sonarcloud bot commented Nov 11, 2024

@mmilko01 mmilko01 merged commit 48dd15d into main Nov 11, 2024
13 checks passed
@mmilko01 mmilko01 deleted the fix/2520/refresh-descriptor-after-manifest-chenges branch November 11, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adp-tooling bug Something isn't working preview-middleware @sap-ux/preview-middleware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants