Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return null value for expression type null #2091

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Jimmy-Joseph19
Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 commented Jun 28, 2024

Skip updating value to null when existing value is null in the document.
Currently the value is set to empty and leading to compilation error.

@Jimmy-Joseph19 Jimmy-Joseph19 requested a review from a team as a code owner June 28, 2024 09:42
Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: 39f8470

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/fiori-annotation-api Patch
@sap-ux/annotation-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Straight forward change
  • Good code coverage
  • Did not test locally

Copy link

sonarcloud bot commented Jul 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants