-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2007/create cf deploy config writer #2139
Conversation
…/create-deploy-config-writer
…/create-deploy-config-writer
🦋 Changeset detectedLatest commit: 0599cea The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…/create-deploy-config-writer
…:SAP/open-ux-tools into feature/2007/create-deploy-config-writer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is well structured and documented
Coverage > 90%
Changeset ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @longieirl
- Not tested locally
- Coverage is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New module step looks good and covered by tests.
ui5 config changes lg.
Changeset ✅
Quality Gate passedIssues Measures |
* origin/main: fix fiori freestyle writer path issue (#2532) chore: apply latest changesets feat(ui-prompting): enhancement for translation input to provide annotation information of translation entry (#2448) chore: apply latest changesets Feature/2007/create cf deploy config writer (#2139) chore: apply latest changesets Update locate-reuse-lib.js ui5 linter issues (#2334)
Fix for #2007
a. Add CF deployment config to an existing HMTL5 application
b. To generate a base CF config i.e. standalone or managed
MtaConfig
class will provide a wrapper for the@sap/mta-lib
to editmta.yaml
files used in the CF generation flow.