Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2007/create cf deploy config writer #2139

Merged
merged 61 commits into from
Nov 5, 2024

Conversation

longieirl
Copy link
Contributor

Fix for #2007

  • Introduce a new cf-deploy-config-writer, will be used CF deployment flows to support the following;
    a. Add CF deployment config to an existing HMTL5 application
    b. To generate a base CF config i.e. standalone or managed
  • MtaConfig class will provide a wrapper for the @sap/mta-lib to edit mta.yaml files used in the CF generation flow.

@longieirl longieirl self-assigned this Jul 10, 2024
Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: 0599cea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@sap-ux/cf-deploy-config-writer Patch
@sap-ux/ui5-config Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/cards-editor-config-writer Patch
@sap-ux/create Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/launch-config Patch
@sap-ux/mockserver-config-writer Patch
@sap-ux/odata-service-writer Patch
@sap-ux/project-access Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-application-writer Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/ui5-proxy-middleware Patch
@sap-ux/preview-middleware Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/annotation-generator Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cards-editor-middleware Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/fe-fpm-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cianmSAP
cianmSAP previously approved these changes Oct 18, 2024
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is well structured and documented
Coverage > 90%
Changeset ✅

Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approval

Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @longieirl

  • Not tested locally
  • Coverage is good

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module step looks good and covered by tests.
ui5 config changes lg.
Changeset ✅

Copy link

sonarcloud bot commented Nov 5, 2024

@longieirl longieirl merged commit 6275288 into main Nov 5, 2024
13 checks passed
@longieirl longieirl deleted the feature/2007/create-deploy-config-writer branch November 5, 2024 21:33
devinea added a commit that referenced this pull request Nov 6, 2024
* origin/main:
  fix fiori freestyle writer path issue (#2532)
  chore: apply latest changesets
  feat(ui-prompting): enhancement for translation input to provide annotation information of translation entry (#2448)
  chore: apply latest changesets
  Feature/2007/create cf deploy config writer (#2139)
  chore: apply latest changesets
  Update locate-reuse-lib.js ui5 linter issues (#2334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants