Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modified indicators incorrectly displayed for some UI5 controls in Adaptation Project #2264

Merged
merged 68 commits into from
Oct 25, 2024

Conversation

mmilko01
Copy link
Contributor

@mmilko01 mmilko01 commented Aug 21, 2024

Fix for #2263.

  • fixes incorrect change indicators for renameLabel, addFields, addGroup changes.
  • adds a new component for 'control' kind changes that have a controlId(selector.id in the change) to visualize in the changes panel.

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: d475015

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sap-ux-private/control-property-editor-common Patch
@sap-ux/control-property-editor Patch
@sap-ux/preview-middleware Patch
@sap-ux-private/preview-middleware-client Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace requested a review from a team August 27, 2024 07:33
@nikmace nikmace added bug Something isn't working preview-middleware-client control-property-editor @sap-ux/control-property-editor control-property-editor-common @sap-ux-private/control-property-editor-common labels Aug 27, 2024
@mmilko01 mmilko01 marked this pull request as ready for review September 11, 2024 13:02
@mmilko01 mmilko01 requested review from a team as code owners September 11, 2024 13:02
@voicis voicis self-requested a review September 11, 2024 13:55
@edingerk
Copy link
Member

the usage of the fl library looks fine. I will document in openui5 that they are used here

@voicis voicis self-requested a review October 24, 2024 08:05
voicis
voicis previously approved these changes Oct 24, 2024
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code changes looks good
  • Good test coverage
  • Review comments addressed
  • Tested locally

nikmace
nikmace previously approved these changes Oct 24, 2024
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Coverage is good
Comments addressed
Tested manually

@Jimmy-Joseph19 Jimmy-Joseph19 removed the request for review from a team October 25, 2024 09:19
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

Copy link

sonarcloud bot commented Oct 25, 2024

@mmilko01 mmilko01 merged commit 5ec7106 into main Oct 25, 2024
13 checks passed
@mmilko01 mmilko01 deleted the fix/2263/incorrect-modified-indicators branch October 25, 2024 13:52
devinea added a commit that referenced this pull request Oct 25, 2024
…pdate

* origin/main:
  chore: apply latest changesets
  fix: Modified indicators incorrectly displayed for some UI5 controls in Adaptation Project (#2264)
  chore: apply latest changesets
  fix(ui-components): `calloutCollisionTransformation` gets overwritten when external listeners are passed(calloutProps.preventDismissOnEvent, calloutProps.layerProps.onLayerDidMount, calloutProps.layerProps.onLayerWillUnmount) (#2497)
  chore: apply latest changesets
  Feat/create command for variants configuration (#2446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working control-property-editor @sap-ux/control-property-editor control-property-editor-common @sap-ux-private/control-property-editor-common preview-middleware-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants