-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Modified indicators incorrectly displayed for some UI5 controls in Adaptation Project #2264
Conversation
🦋 Changeset detectedLatest commit: d475015 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ub.com/SAP/open-ux-tools into fix/2263/incorrect-modified-indicators
the usage of the fl library looks fine. I will document in openui5 that they are used here |
…ub.com/SAP/open-ux-tools into fix/2263/incorrect-modified-indicators
…ub.com/SAP/open-ux-tools into fix/2263/incorrect-modified-indicators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code changes looks good
- Good test coverage
- Review comments addressed
- Tested locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Coverage is good
Comments addressed
Tested manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
Quality Gate passedIssues Measures |
…pdate * origin/main: chore: apply latest changesets fix: Modified indicators incorrectly displayed for some UI5 controls in Adaptation Project (#2264) chore: apply latest changesets fix(ui-components): `calloutCollisionTransformation` gets overwritten when external listeners are passed(calloutProps.preventDismissOnEvent, calloutProps.layerProps.onLayerDidMount, calloutProps.layerProps.onLayerWillUnmount) (#2497) chore: apply latest changesets Feat/create command for variants configuration (#2446)
Fix for #2263.