Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scripts variant management script to FF & FE package json #2327

Merged
merged 19 commits into from
Sep 23, 2024
Merged

Add scripts variant management script to FF & FE package json #2327

merged 19 commits into from
Sep 23, 2024

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Sep 5, 2024

#2326

  • Added start-variants-management to FE and FF
  • Added a shared function getVariantPreviewAppScript to fiori-generated-shared
  • Added Unit tests & updated snapshots

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6167859

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@sap-ux/fiori-freestyle-writer Minor
@sap-ux/fiori-generator-shared Minor
@sap-ux/ui5-application-writer Minor
@sap-ux/fiori-elements-writer Minor
@sap-ux/odata-service-writer Minor
@sap-ux/ui5-config Minor
@sap-ux/generator-simple-fe Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/cap-config-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/cards-editor-config-writer Patch
@sap-ux/create Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/launch-config Patch
@sap-ux/mockserver-config-writer Patch
@sap-ux/project-access Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-proxy-middleware Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/annotation-generator Patch
@sap-ux/cards-editor-middleware Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/fe-fpm-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjose90 kjose90 marked this pull request as ready for review September 5, 2024 13:59
@kjose90 kjose90 requested review from a team as code owners September 5, 2024 13:59
IainSAP
IainSAP previously approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kjose90

  • Updates look correct to add script
  • Tests added to cover

longieirl
longieirl previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Havent test locally.
Appropiate test changes to cover change.
Comments addressed.

IainSAP
IainSAP previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kjose90

  • Changes as expected
  • Tests updated as expected

@kjose90
Add sapuxlayer to package json (#2359)
fe1c8d2 
* add sapuxlayer

* document sapuxLayer property

* update snap shots and set default sapuxLayer

* update test name

* Update index.ts fix typp

* reverting default sap ux layer settings

* use package type from project-access in ui5-application-writer
@kjose90 kjose90 dismissed stale reviews from IainSAP and longieirl via fe1c8d2 September 18, 2024 13:46
@kjose90 kjose90 requested a review from a team as a code owner September 18, 2024 13:46
@kjose90
Add ignore cert error to odata-service-writer (#2343)
e43334f 
* add ignore cert error to odata service writer and ui5 config

* lint issues
@kjose90 kjose90 requested review from a team as code owners September 18, 2024 13:47
kjose90 and others added 4 commits September 20, 2024 08:27
@kjose90 @devinea
Add fiori-tools-preview middleware to ui5 yamls (#2382)
c26c5f5 
* update fiori preview middleares

* add fiori preview & update snapshots

* add doc to firori middlware type

* Create thin-numbers-repair.md

* Delete .changeset/thin-numbers-repair.md

---------

Co-authored-by: Austin Devine <[email protected]>
@kjose90
Merge branch 'main' into start-variants-management-script
4cd1c3b
@kjose90
adding default app name to simple generator example app
d448731
@kjose90
update changeset
0fc1abe
devinea
devinea approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes are clear. Snapshot changes appear valid.
Changeset ✅

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

longieirl
longieirl approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving.
A number of issues being followed up with another PR.

@kjose90
Copy link
Member Author

kjose90 commented Sep 23, 2024

Thanks for review - 1 Issue in this PR is simplar to issues being reported here where UI5Config is a reference it itself. This will be fixed in another PR.

@kjose90 kjose90 merged commit 484195d into main Sep 23, 2024
13 checks passed
@kjose90 kjose90 deleted the start-variants-management-script branch September 23, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinea devinea devinea approved these changes

@longieirl longieirl longieirl approved these changes

@IainSAP IainSAP IainSAP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjose90 @longieirl @devinea @IainSAP